openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update nova from branch 'master'
  to 5eab13030bc2708c8900f7ac1bdbc8a111f5f823
  - Merge "api: Reject requests to force up computes when `done` evacuation records exist"
  - api: Reject requests to force up computes when `done` evacuation records exist
    
    When evacuating an instance the evacuation migration record moves from a
    state of `accepted` to `pre-migrating` and eventually `done` once the
    instance has been rebuilt on the new compute host. At present the
    migration record remains in this state until the original compute host
    is restarted and the service cleans up any leftovers of the instance
    before it is moved to a state of `completed`.
    
    Bug #1922053 details a use case where an operator might unintentionally
    forget to ensure the compute service is restarted before forcing the
    service up leaving evacuation migration records stuck as `done`.
    
    This could become an issue in the future if the instance is moved back
    to this compute before the service is restarted. Any future restart
    invoking the cleanup logic and potentially damaging the running
    instance.
    
    This change aims to address this by blocking requests to force up
    computes associated to `done` evacuation records. Forcing operators to
    restart the service allowing them to move to a `completed` state before
    the service can be forced up again.
    
    To allow this to be backportable these requests are rejected with a 400
    BadRequest return code from the API. A TODO is left to move this to a
    409 Conflict during the Xena release under a new microversion.
    
    Finally, some additional functional tests have been updated to ensure
    they restart the source compute service of an evacuation before
    attempting to force up the service, ensuring any migration records are
    marked as completed.
    
    Closes-Bug: #1922053
    Change-Id: I95882ea28564a31a6b4f8b665de462774d84edfc
This commit is contained in:
Zuul 2021-04-15 09:44:19 +00:00 committed by Gerrit Code Review
parent d2d7c53a3f
commit 94d293a283
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova

@ -1 +1 @@
Subproject commit 86195459c7f200c10df112a3c670fc2d885400e0
Subproject commit 5eab13030bc2708c8900f7ac1bdbc8a111f5f823