openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update ansible-role-tripleo-modify-image from branch 'master'
  - Add double quotes around the printf statements in yum_update.sh
    
    This is consistent with the other printf statements in the file. This
    keeps the sorted data with the newlines as they are, and avoids
    breaking down the data again. Otherwise, the sorting order can be
    altered which breaks comm comparison and causes the "Run yum_update.sh"
    task to fail with the following error:
    
        "stderr_lines": [
            "comm: file 2 is not in sorted order",
            "error while running runtime: exit status 1"
        ],
    
    This is particularly important for the $available variable which
    contains the repoquery output, often very large and with unusual
    characters. The error happens consistently when including RHEL 7 server
    repos or RHEL 8 BaseOS repo and prevents the update from working at
    all.
    
    This patch also adds -u when sorting the $available output. Once the
    versions are removed with cut, there can be a tremendous amount of
    duplication in the data obtained from repoquery. That makes verbose
    mode even more difficult to navigate when debugging.
    
    Change-Id: Id64a8c2e395de28945d5d6b4370c44b80392e543
This commit is contained in:
Julie Pichon 2020-01-16 12:59:56 +00:00 committed by Gerrit Code Review
parent a0fa6d3a78
commit b222fc3774
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible-role-tripleo-modify-image

@ -1 +1 @@
Subproject commit eff235ee7274f0d4a9c71bf0d971d93fd5e3d339
Subproject commit bb6f78deca04e23cdf42c7be78af8d099f24a41a