openstack
/
openstack
Code Issues Proposed changes

Updated openstack/openstack 

Project: openstack-infra/jenkins-job-builder  b58f6b17de4750c2408e6e8f9d6778f4e3bc289d

Move macro expansion into YamlParser.

Introduce the registry.MacroRegistry class to handle:
 * registration of macro types via setuptools' entrypoints
 * registration of individual macros for lookup by component list type
 * expansion of macros references during YAML "parsing"

As a consequence there is a reduction in performance due to moving the
expansion of macros from inline with XML generation, to requiring
multiple passes over macro component lists.

This decrease in efficiency results in approx ~30-50% increase in unit
test time. Since this will allow for jobs to be expanded from
templates/macros in parallel with future changes, it is a reasonable
short term trade-off as the most computationally expensive task is
updating the definitions on the remote master

Change-Id: I292c6b1f8472370282205426cd8ceb847eb969bd
This commit is contained in:
Jenkins 2017-09-08 15:41:08 +00:00 committed by Gerrit Code Review
parent 9f230aeff2
commit bb9bc6cae7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jenkins-job-builder

@ -1 +1 @@
Subproject commit f2b01f7c5ca29f6cf3fa1040106ed9d81fad32af
Subproject commit b58f6b17de4750c2408e6e8f9d6778f4e3bc289d