openstack
/
openstacksdk
Code Issues Proposed changes

Use Message.existing() to create existing messages 

When the messages have been created by the service we can simply use the
Message.existing() function to create a message to return with
loaded=True.

Change-Id: I7c013e97b7a8ff1badf6e5a45a5b485c62a28261
This commit is contained in:
Everett Toews 2015-06-26 14:07:12 -05:00
parent 1862b37b61
commit 2673392fea
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openstack/message/v1/message.py
View File

@ -10,7 +10,6 @@
# License for the specific language governing permissions and limitations
# under the License.
import copy
import json
from six.moves.urllib import parse
@ -73,13 +72,15 @@ class Message(resource.Resource):
resp = session.post(url, service=cls.service, headers=headers,
data=json.dumps(messages, cls=MessageEncoder))
messages_deepcopy = copy.deepcopy(messages)
messages_created = []
hrefs = resp.body['resources']
for i, href in enumerate(hrefs):
messages_deepcopy[i].href = href
message = Message.existing(**messages[i])
message.href = href
messages_created.append(message)
return messages_deepcopy
return messages_created
@classmethod
def _strip_version(cls, href):