openstack
/
openstacksdk
Code Issues Proposed changes

Floating ip does not have an id 

1) Floating ip does not have an id, it uses floating_ip_address
   as the key.
2) There is no attribute that is similar to a name.
3) Set resource_name for person friendly print.

Change-Id: I9e0d21dcf446ad19fe416a868e3ddfa804b99f36
This commit is contained in:
Terry Howe 2014-09-20 08:57:08 -06:00
parent 406838e70b
commit 5f3ca6406d
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack/network/v2/floatingip.py
View File

@ -15,6 +15,9 @@ from openstack import resource
class FloatingIP(resource.Resource):
id_attribute = "floating_ip_address"
name_attribute = None
resource_name = "floating ip"
resource_key = 'floatingip'
resources_key = 'floatingips'
base_path = '/v2.0/floatingips'

7
openstack/tests/network/v2/test_floatingip.py
View File

@ -14,12 +14,11 @@ import testtools
from openstack.network.v2 import floatingip
IDENTIFIER = 'IDENTIFIER'
IDENTIFIER = '10.0.0.1'
EXAMPLE = {
'fixed_ip_address': '1',
'floating_ip_address': '2',
'floating_ip_address': IDENTIFIER,
'floating_network_id': '3',
'id': IDENTIFIER,
'port_id': '5',
'tenant_id': '6',
'router_id': '7',
@ -47,7 +46,7 @@ class TestFloatingIP(testtools.TestCase):
sot.floating_ip_address)
self.assertEqual(EXAMPLE['floating_network_id'],
sot.floating_network_id)
self.assertEqual(EXAMPLE['id'], sot.id)
self.assertEqual(EXAMPLE['floating_ip_address'], sot.id)
self.assertEqual(EXAMPLE['port_id'], sot.port_id)
self.assertEqual(EXAMPLE['tenant_id'], sot.project_id)
self.assertEqual(EXAMPLE['router_id'], sot.router_id)