Update patch set 1

Patch Set 1:

(4 comments)

Patch-set: 1
This commit is contained in:
Gerrit User 10115 2023-06-14 17:26:45 +00:00 committed by Gerrit Code Review
parent ae1b11958c
commit 175f81771d
1 changed files with 69 additions and 0 deletions

View File

@ -34,6 +34,23 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "663a1426_027180da",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 10115
},
"writtenOn": "2023-06-14T17:26:45Z",
"side": 1,
"message": "Let me add answers for some questions.",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -295,6 +312,58 @@
"message": "Would it be possible to get some description of what the configuration represents? Specifically, I\u0027m wondering why a range is even required.",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9c429a3f_02867258",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 225,
"author": {
"id": 10115
},
"writtenOn": "2023-06-14T17:26:45Z",
"side": 1,
"message": "The port_range is used to launch RPC server which is used to access from RPC client with hostname like \u003chsotname\u003e:\u003cport\u003e style.\n\nLimiting port_range is introduced for security reason to support precise access control from RPC client access. But I suppose this is optional feature.",
"parentUuid": "ed79b153_1369cfc0",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba06bfa8_f1752440",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 233,
"author": {
"id": 10115
},
"writtenOn": "2023-06-14T17:26:45Z",
"side": 1,
"message": "Parameters in [consul] section are used for access to Consul or health check from Consul.\n\nport: Consul\u0027s port number which is used to fetch endpoint information from RPC client or register RPC information from RPC server.\n\ncheck_timeout: Health check configuration from Consul cluster to RPC server.\nOnce this timeout is passed without health check response, endpoint is automatically marked as down status and client can not get this endpoint from list.\n\ncheck_deregister: If the RPC server does not respond health check more than this time, the endpoint is removed automatically from Consul.",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1a81d925_f38b50f8",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 241,
"author": {
"id": 10115
},
"writtenOn": "2023-06-14T17:26:45Z",
"side": 1,
"message": "Parameters in [http_driver] section is used for launching RPC server using OpenAPI.\n\nlisten_timeout: OpenAPI server\u0027s listen timeout until callback function for RPC request returns the execution result.",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}