openstack
/
oslo-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(8 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10115\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 10115 \u003c10115@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10115\u003e replied on the change"}
This commit is contained in:
Gerrit User 10115 2023-06-26 10:38:03 +00:00 committed by Gerrit Code Review
parent 22466664cc
commit 2befb6736a
2 changed files with 183 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
67cc07b837c4611ed69d4ae8d69d84942608b656 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "14abd93e_cdbe51e7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Stephen, Takashi,\nThank you for your review and sorry for the late reply. I have addressed some comments.\n\n\u003eIt would be helpful to give a concrete example of how these would map to service of an openstack service like nova, ironic etc.\n\nFor this comment, I will take screenshot of our test Consul cluster and upload image which shows service information registered in Consul.",
"revId": "67cc07b837c4611ed69d4ae8d69d84942608b656",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

162
e630fcf831b4d8e8cbc9f185a5afd00317575c34
View File

@ -98,6 +98,30 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d1bbdb54_00b2d394",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 88,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "a1b74221_a3516d25",
"range": {
"startLine": 88,
"startChar": 32,
"endLine": 88,
"endChar": 36
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +139,24 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "700f9bea_4e24b6b3",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 91,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Thank you for the comment. I will update our Consul cluster\u0027s Screen shot to understand the mapping information of OpenStack service.",
"parentUuid": "1f28761e_82d6866e",
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +180,30 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fd6d47f3_1c5bc7d5",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 106,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "a13b16aa_3cde0168",
"range": {
"startLine": 106,
"startChar": 49,
"endLine": 106,
"endChar": 54
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -208,6 +274,30 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f4169d05_9d51975d",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 114,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "f97a6eef_3f84de06",
"range": {
"startLine": 114,
"startChar": 16,
"endLine": 114,
"endChar": 25
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -231,6 +321,30 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b1fbcf60_7e4b71b7",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 117,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "0b03acf3_1fdfc339",
"range": {
"startLine": 117,
"startChar": 0,
"endLine": 117,
"endChar": 6
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -406,6 +520,30 @@
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "842e3600_bf457735",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 205,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "a86202d5_5463b246",
"range": {
"startLine": 205,
"startChar": 0,
"endLine": 205,
"endChar": 7
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -497,6 +635,30 @@
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f5166785_8d336c31",
"filename": "specs/bobcat/http-driver.rst",
"patchSetId": 1
},
"lineNbr": 253,
"author": {
"id": 10115
},
"writtenOn": "2023-06-26T10:38:03Z",
"side": 1,
"message": "Done",
"parentUuid": "47da4af5_0795233b",
"range": {
"startLine": 253,
"startChar": 20,
"endLine": 253,
"endChar": 30
},
"revId": "e630fcf831b4d8e8cbc9f185a5afd00317575c34",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}