openstack
/
oslo-specs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 30491 2022-10-06 18:34:25 +00:00 committed by Gerrit Code Review
parent 0126ba50d5
commit 4e06dad792
1 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
cda4dc79e1fa3d16bf406fd109d74dd0d9870690
View File

@ -17,6 +17,29 @@
"revId": "cda4dc79e1fa3d16bf406fd109d74dd0d9870690",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4b7bd883_3cf6acfc",
"filename": "specs/antelop/nats-transport.rst",
"patchSetId": 6
},
"lineNbr": 186,
"author": {
"id": 30491
},
"writtenOn": "2022-10-06T18:34:25Z",
"side": 1,
"message": "No, only eventlet is about monkey-patching. Greenlet only gives the greenlets/microthreads/lightweight_threads/magic_coroutines - you name it.",
"range": {
"startLine": 186,
"startChar": 9,
"endLine": 186,
"endChar": 21
},
"revId": "cda4dc79e1fa3d16bf406fd109d74dd0d9870690",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -73,6 +96,40 @@
},
"revId": "cda4dc79e1fa3d16bf406fd109d74dd0d9870690",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3d1b9a47_119dee10",
"filename": "specs/antelop/nats-transport.rst",
"patchSetId": 6
},
"lineNbr": 207,
"author": {
"id": 30491
},
"writtenOn": "2022-10-06T18:34:25Z",
"side": 1,
"message": "They did not. See also the comment I left on [9] below.",
"revId": "cda4dc79e1fa3d16bf406fd109d74dd0d9870690",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c98b091a_79782954",
"filename": "specs/antelop/nats-transport.rst",
"patchSetId": 6
},
"lineNbr": 308,
"author": {
"id": 30491
},
"writtenOn": "2022-10-06T18:34:25Z",
"side": 1,
"message": "This only really discusses how SQLAlchemy drives synchronous and asynchronous stuff in the same codebase. It explicitly mentions that gevent and eventlet are not in use - we seem unable to afford that.",
"revId": "cda4dc79e1fa3d16bf406fd109d74dd0d9870690",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}