openstack
/
oslo-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+2

(8 comments)

Patch-set: 2
Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 15334 2022-05-16 07:55:14 +00:00 committed by Gerrit Code Review
parent 368bcb109a
commit 7c567f8a7f
1 changed files with 178 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

178
fb691375b99b7470ad4ceda6cea9badac1a46ab3
View File

@ -34,6 +34,23 @@
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e772f094_98f78e01",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "Couple of nits inline. I\u0027ll respin to fix these myself and then approve ",
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -57,6 +74,167 @@
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "32ae0788_fe16276a",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 16,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "from",
"range": {
"startLine": 16,
"startChar": 25,
"endLine": 16,
"endChar": 29
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0bf6dadb_850e32b9",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 17,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "non-local",
"range": {
"startLine": 17,
"startChar": 40,
"endLine": 17,
"endChar": 49
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "220e598b_fdd13f28",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 21,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": ", I",
"range": {
"startLine": 21,
"startChar": 14,
"endLine": 21,
"endChar": 16
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "45c4b6e3_80b9e5be",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 31,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "notifications",
"range": {
"startLine": 31,
"startChar": 10,
"endLine": 31,
"endChar": 22
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f5f3fd16_c6853ad6",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 31,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "no",
"range": {
"startLine": 31,
"startChar": 36,
"endLine": 31,
"endChar": 39
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "22306a5e_fedd04d3",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "Multiple clients",
"range": {
"startLine": 33,
"startChar": 1,
"endLine": 33,
"endChar": 15
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f6483dc1_6de12d22",
"filename": "specs/zed/unix-socket-oslo-messaging-notifcations-driver.rst",
"patchSetId": 2
},
"lineNbr": 36,
"author": {
"id": 15334
},
"writtenOn": "2022-05-16T07:55:14Z",
"side": 1,
"message": "JSON",
"range": {
"startLine": 36,
"startChar": 76,
"endLine": 36,
"endChar": 80
},
"revId": "fb691375b99b7470ad4ceda6cea9badac1a46ab3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {