openstack
/
oslo.cache
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 31245 \u003c31245@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36624\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36624 \u003c36624@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36624\u003e replied on the change"}
This commit is contained in:
Gerrit User 36624 2024-02-02 11:06:49 +00:00 committed by Gerrit Code Review
parent 692c103ef3
commit 2f6ef50ba0
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
77d3f5405fcf14f1c70f249edf59a4f13d5aa12e
View File

@ -174,6 +174,24 @@
"message": "Sorry can you explain what you want here please? The comment is a bit confusing for me. We don\u0027t remove the username and password here.",
"revId": "77d3f5405fcf14f1c70f249edf59a4f13d5aa12e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "762c8ed2_0f0fa206",
"filename": "oslo_cache/core.py",
"patchSetId": 2
},
"lineNbr": 167,
"author": {
"id": 36624
},
"writtenOn": "2024-02-02T11:06:49Z",
"side": 1,
"message": "Maybe you don\u0027t remove them intentionally, without the if statement it removes them, or rather they don\u0027t appear in the final `config_dict` this function returns.",
"parentUuid": "e07d28d1_e9aa204e",
"revId": "77d3f5405fcf14f1c70f249edf59a4f13d5aa12e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}