Update patch set 3

Patch Set 3:

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 32553 <32553@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32553\u003e replied on the change"}
This commit is contained in:
Gerrit User 32553 2024-01-31 16:54:59 +00:00 committed by Gerrit Code Review
parent 608670fb9d
commit 3648c0cc97
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f4eaca76_c7723190",
"filename": "oslo_cache/core.py",
"patchSetId": 3
},
"lineNbr": 109,
"author": {
"id": 32553
},
"writtenOn": "2024-01-31T16:54:59Z",
"side": 1,
"message": "I\u0027m not sure using regex to parse/validate IPv4|6 is a good idea. Why not use the standard library function for that? (it might require more work, but also provide a cleaner interface).\nhttps://docs.python.org/3/library/ipaddress.html\n\nalso this conflates \"localhost\" with IPv4, when localhost also can resolve to an IPv6 address.",
"range": {
"startLine": 105,
"startChar": 4,
"endLine": 109,
"endChar": 46
},
"revId": "1c654d513eab184ca4e3e3b7b0fc47270f953c01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}