openstack
/
oslo.cache
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(2 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36624 \u003c36624@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2024-02-03 04:45:24 +00:00 committed by Gerrit Code Review
parent e42780ba6f
commit 7cf1796543
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
9415450a1fccd08cdae2370d29a10945260d026b
View File

@ -111,6 +111,54 @@
},
"revId": "9415450a1fccd08cdae2370d29a10945260d026b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3907d5fb_a53f5a52",
"filename": "oslo_cache/core.py",
"patchSetId": 11
},
"lineNbr": 263,
"author": {
"id": 9816
},
"writtenOn": "2024-02-03T04:45:24Z",
"side": 1,
"message": "I\u0027m building a reproducer now, but I guess the default value if memcache_server, which is used to set the url argument may hide user/password and I wonder if we can try\n\nmemcache_server\u003dredis://:\u003cpassword\u003e",
"parentUuid": "11f489a1_e3e657e7",
"range": {
"startLine": 263,
"startChar": 20,
"endLine": 263,
"endChar": 31
},
"revId": "9415450a1fccd08cdae2370d29a10945260d026b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9de36fa4_d1b560a5",
"filename": "oslo_cache/core.py",
"patchSetId": 11
},
"lineNbr": 263,
"author": {
"id": 9816
},
"writtenOn": "2024-02-03T04:45:24Z",
"side": 1,
"message": "Hmm. I set up my local reproducer but I can\u0027t reproduce the problem you have.\nI\u0027m dumping snippets from my local files. I wonder if you can compare specifically redis and sentinel config you have in your env.\n\n```\n[cache]\nbackend\u003ddogpile.cache.redis_sentinel\nbackend_argument \u003d sentinels:127.0.0.1:26379\nenabled\u003dTrue\nmemcache_password \u003d a_big_secret\ntls_enabled \u003d true\ntls_cafile \u003d /etc/pki/tls/certs/ca-bundle.crt\ntls-replication yes\n```\n\nredis.conf\n```\nport 0\ntls-port 6379\ntls-cert-file /etc/pki/ca-trust/source/anchors/puppet_openstack.pem\ntls-key-file /etc/redis/ssl/private/localhost.localdomain.pem\ntls-ca-cert-file /etc/ssl/certs/ca-bundle.crt\ntls-auth-clients no\ntls-replication yes\n...\nrequirepass a_big_secret\n```\n\nsentinel.conf\n```\nbind 127.0.0.1\nport 0\ntls-port 26379\ndir \"/tmp\"\ndaemonize no\nsupervised systemd\npidfile \"/var/run/redis/redis-sentinel.pid\"\nprotected-mode yes\nsentinel monitor mymaster 127.0.0.1 6379 1\nsentinel auth-pass mymaster a_big_secret\nrequirepass \"a_big_secret\"\ntls-cert-file \"/etc/pki/ca-trust/source/anchors/puppet_openstack.pem\"\ntls-key-file \"/etc/redis/ssl/private/localhost.localdomain.pem\"\ntls-ca-cert-file \"/etc/ssl/certs/ca-bundle.crt\"\ntls-auth-clients no\ntls-replication yes\ntls-protocols \"TLSv1.2\"\nloglevel notice\nlogfile \"/var/log/redis/sentinel.log\"\nuser default on #a9641de0cc33e927193d784499fd85e0d155a37102075c6dccf4d74688722742 ~* \u0026* +@all\nsentinel myid 536661e1f02791cbd09086b706ac6a1728111f0e\nsentinel config-epoch mymaster 0\nsentinel leader-epoch mymaster 9\nsentinel current-epoch 9\n```",
"parentUuid": "11f489a1_e3e657e7",
"range": {
"startLine": 263,
"startChar": 20,
"endLine": 263,
"endChar": 31
},
"revId": "9415450a1fccd08cdae2370d29a10945260d026b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}