Update patch set 9
Patch Set 9: Code-Review-1 (4 comments) Patch-set: 9 Reviewer: Gerrit User 36624 <36624@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 0ccd93fa60005b97f34cc3d36d67864033839a93 Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36624\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 36624 \u003c36624@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36624\u003e replied on the change"}
This commit is contained in:
parent
0a5a58c907
commit
b195fa67aa
|
@ -34,6 +34,24 @@
|
|||
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c6f7a6f4_dc637d31",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 36624
|
||||
},
|
||||
"writtenOn": "2024-02-02T12:15:26Z",
|
||||
"side": 1,
|
||||
"message": "I am unable to run this with implementation in my Kolla setup. \nI did and I think username/password providing might be the issue here.",
|
||||
"parentUuid": "a3abb7c2_25412762",
|
||||
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
@ -0,0 +1,61 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "01f88dfc_16d9d11c",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 36624
|
||||
},
|
||||
"writtenOn": "2024-02-02T12:15:26Z",
|
||||
"side": 1,
|
||||
"message": "What\u0027s a correct way of providing Redis username and password?",
|
||||
"revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "d7dcd1e8_de042113",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 36624
|
||||
},
|
||||
"writtenOn": "2024-02-02T12:15:26Z",
|
||||
"side": 1,
|
||||
"message": "I cannot run this in Kolla using the example config from commit message.",
|
||||
"revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "29745f56_b14119c2",
|
||||
"filename": "oslo_cache/core.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 261,
|
||||
"author": {
|
||||
"id": 36624
|
||||
},
|
||||
"writtenOn": "2024-02-02T12:15:26Z",
|
||||
"side": 1,
|
||||
"message": "What is \u0027client_kwargs\u0027? AFAIK there\u0027s no such thing in [redis-py](https://github.com/search?q\u003drepo%3Aredis%2Fredis-py%20client_kwargs\u0026type\u003dcode)\nor [dogpile.cache](https://github.com/search?q\u003drepo%3Asqlalchemy%2Fdogpile.cache%20client_kwargs\u0026type\u003dcode) source code. Am I missing something here or did you mean `connection_kwargs`",
|
||||
"range": {
|
||||
"startLine": 261,
|
||||
"startChar": 20,
|
||||
"endLine": 261,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "8f1042cb39098246de8c5ccac76947559fb9d8d6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue