Add exclude-groups option to config validator

When dynamic groups are used, the sample config data may not know
about those group names. As a result, validation of such files will
always fail. This makes it hard to automate config checks since the
output would need to be inspected manually to verify that the missing
options are all from the dynamic group.

Ideally, we would provide some way to map sample config groups to
the dynamic group name used in the actual config, but that would be
more complicated and still might not work in every case if a project
doesn't include sample sections for a dynamic group (although they
_should_ be doing so).

Allowing certain group names to be excluded from validation lets
us to solve this problem in a simple way and maintain validation of
99%[0] of the config options and enables the validation to be scripted
since it won't need manual verification of the error output.

Change-Id: I352fd48f86ecb876fe26a5e50e9a2633af1fff3d
0: citation needed ;-)
This commit is contained in:
Ben Nemec 2019-03-26 16:08:44 +00:00
parent c6631d3825
commit c30d9c0a08
3 changed files with 25 additions and 0 deletions

View File

@ -61,3 +61,12 @@ a sample config file ``config-data.yaml`` created by the config generator::
ERROR:root:keystone_authtoken/project_name not found
ERROR:root:keystone_authtoken/password not found
ERROR:root:keystone_authtoken/auth_url not found
Handling Dynamic Groups
-----------------------
Some services register group names dynamically at runtime based on other
configuration. This is problematic for the validator because these groups won't
be present in the sample config data. The ``--exclude-group`` option for the
validator can be used to ignore such groups and allow the other options in a
config file to be validated normally.

View File

@ -48,6 +48,12 @@ _validator_opts = [
'fatal-warnings',
default=False,
help='Report failure if any warnings are found.'),
cfg.MultiStrOpt(
'exclude-group',
default=[],
help='Groups that should not be validated if they are present in the '
'specified input-file. This may be necessary for dynamically '
'named groups which do not appear in the sample config data.'),
]
@ -96,6 +102,8 @@ def _validate(conf):
warnings = False
errors = False
for section, options in sections.items():
if section in conf.exclude_group:
continue
for option in options:
if _validate_deprecated_opt(section, option, opt_data):
logging.warn('Deprecated opt %s/%s found', section, option)

View File

@ -0,0 +1,8 @@
---
features:
- |
The ``oslo-config-validator`` tool now has a new option,
``--exclude-group``, that allows deployers to ignore certain groups that
might not appear in the sample config data, perhaps because the name of
the group depends on other configuration values. This way the validator
can still be used on the known groups.