Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 597 \u003c597@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_597\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_597\u003e replied on the change"}
This commit is contained in:
Gerrit User 597 2023-03-09 02:17:11 +00:00 committed by Gerrit Code Review
parent acab3a34da
commit 2ee7d25f60
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"message": "These test failures are real. We\u0027ve got mocks of getdefaultlocale which need to be updated. The replacement suggested also feels slightly reductive. Looking at the logic for \u0027getdefaultlocale\u0027 [1], I see use trying multiple envvars. Shouldn\u0027t we be doing the same thing here?\n\n[1] https://github.com/python/cpython/blob/3.11/Lib/locale.py#L534",
"revId": "721dd76cb9a99973ae45cf5ff0e1e2f052281150",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "83271939_08a41fff",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 597
},
"writtenOn": "2023-03-09T02:17:11Z",
"side": 1,
"message": "I think the mechanism of checking environment variables is still present. It\u0027s the difference between looking at the environment (which can be set in any way by the external forces) and looking at the properties of the library. The theory is, the library examines the Linux environment variables on startup, then constructs its state accordingly. This is why it lacks a LANG attribute: the LANG env is parsed into a bunch of LC_xxx attributes. Because we do not parse environment ourselves, fallback is not needed. At least this is how I understand it.\n\nI adjusted the tests, sorry about that.",
"parentUuid": "01e90178_303faa53",
"revId": "721dd76cb9a99973ae45cf5ff0e1e2f052281150",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}