openstack
/
oslo.service
Code Issues Proposed changes

Fix misuse of assertTrue 

Replace assertTrue with assertEqual.

Change-Id: I918930a6fd3980297ee7d68dd6c9397416fb3335
Closes-Bug: 1988308
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
This commit is contained in:
Takashi Natsume 2022-08-31 22:02:39 +09:00
parent 2c32ffdb7d
commit 845fc45fab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_service/tests/test_loopingcall.py
View File

@ -347,7 +347,7 @@ class TestBackOffLoopingCall(test_base.BaseTestCase):
expected_times = [mock.call(1), mock.call(1), mock.call(1)]
self.assertEqual(expected_times, sleep_mock.call_args_list)
self.assertTrue(retvalue, 'return value')
self.assertEqual('return value', retvalue)
@mock.patch('random.SystemRandom.gauss')
@mock.patch('oslo_service.loopingcall.LoopingCallBase._sleep')
@ -360,7 +360,7 @@ class TestBackOffLoopingCall(test_base.BaseTestCase):
retvalue = loopingcall.BackOffLoopingCall(func).start().wait()
self.assertFalse(sleep_mock.called)
self.assertTrue(retvalue, 'return value')
self.assertEqual('return value', retvalue)
@mock.patch('random.SystemRandom.gauss')
@mock.patch('oslo_service.loopingcall.LoopingCallBase._sleep')