From 9a99ddd520b34dd41579e5101b55fa4573bd6653 Mon Sep 17 00:00:00 2001
From: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Tue, 23 May 2023 08:55:53 +0000
Subject: [PATCH] Update patch set 11

Patch Set 11:

(2 comments)

Patch-set: 11
CC: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 7730 \u003c7730@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28522\u003e replied on the change"}
---
 196c9b53145e38a82ed2eead53b4d4aef3a8de66 | 40 ++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/196c9b53145e38a82ed2eead53b4d4aef3a8de66 b/196c9b53145e38a82ed2eead53b4d4aef3a8de66
index 32c09a1..fd3ad1f 100644
--- a/196c9b53145e38a82ed2eead53b4d4aef3a8de66
+++ b/196c9b53145e38a82ed2eead53b4d4aef3a8de66
@@ -1,5 +1,22 @@
 {
   "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1f0912d1_1fa1ae7d",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 11
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 28522
+      },
+      "writtenOn": "2023-05-23T08:55:53Z",
+      "side": 1,
+      "message": "Hello,\n\nFirst thanks for this patch and for all your recent contributions.\n\nSee my inline suggestion.\nAlso I\u0027d suggest you to add some related docs with an example of usecase where user should think about enabling this feature.\n\nElse looks good to me.",
+      "revId": "196c9b53145e38a82ed2eead53b4d4aef3a8de66",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": false,
       "key": {
@@ -46,6 +63,29 @@
       },
       "revId": "196c9b53145e38a82ed2eead53b4d4aef3a8de66",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d500c2c4_524c120b",
+        "filename": "osprofiler/requests.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 28522
+      },
+      "writtenOn": "2023-05-23T08:55:53Z",
+      "side": 1,
+      "message": "Just a `reader` comment.\n\nCan\u0027t we do that directly from line 63?\nThat\u0027s a bit redundant with what its did in the else section of the above `try/except`, and as `else` part is only executed if the `try` part is successful and that the import of `requests` is also successful, so I\u0027d suggest to init everything in the `else` part.\n\nThe `enable` function part would be only the confirmation to the user that http adapter is fully ready to be used by checking the state of `_FUNC` as you already did.",
+      "range": {
+        "startLine": 69,
+        "startChar": 8,
+        "endLine": 69,
+        "endChar": 31
+      },
+      "revId": "196c9b53145e38a82ed2eead53b4d4aef3a8de66",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file