openstack
/
osprofiler
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review+2 Workflow+1

(1 comment)

Patch-set: 12
Reviewer: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 846e79d6cd055611db79ad2c1c934b8fc49481d4
Label: Workflow=+1, 9f70ced4fde0905532067618b3fb1d1405393327
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28522 \u003c28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2023-06-06 08:19:34 +00:00 committed by Gerrit Code Review
parent 252e80639d
commit cf6380fb0e
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
196c9b53145e38a82ed2eead53b4d4aef3a8de66
View File

@ -86,6 +86,30 @@
},
"revId": "196c9b53145e38a82ed2eead53b4d4aef3a8de66",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5a809511_140a124a",
"filename": "osprofiler/requests.py",
"patchSetId": 11
},
"lineNbr": 69,
"author": {
"id": 9816
},
"writtenOn": "2023-06-06T08:19:34Z",
"side": 1,
"message": "I think the point is that we need the warning message in case the user explicitly requests the profiling for requests. Because the whole enable method is called by initializer according to the config knob I think it makes sense to have this logic within enable method.",
"parentUuid": "d500c2c4_524c120b",
"range": {
"startLine": 69,
"startChar": 8,
"endLine": 69,
"endChar": 31
},
"revId": "196c9b53145e38a82ed2eead53b4d4aef3a8de66",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}