parent
ed31ea101e
commit
f3dddfdfa6
|
@ -1,5 +1,28 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "292250a1_8d3d36b1",
|
||||
"filename": "devstack/lib/osprofiler",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 66,
|
||||
"author": {
|
||||
"id": 28522
|
||||
},
|
||||
"writtenOn": "2023-03-30T09:26:35Z",
|
||||
"side": 1,
|
||||
"message": "Do we need to publish all these features?\nBy example I\u0027m not convinced that we will use node.js (6832) in our openstack context.\n\nApparently we want to use 4318 in our context, so I wonder if publishing all these ports is mandatory because IMO it can cause security issues at some points if some CVE are discovered for one of them, so I\u0027d suggest to reduce the opened windows only to the ports we really needs.\n\nhttps://www.jaegertracing.io/docs/1.43/getting-started/#all-in-one",
|
||||
"range": {
|
||||
"startLine": 66,
|
||||
"startChar": 117,
|
||||
"endLine": 66,
|
||||
"endChar": 262
|
||||
},
|
||||
"revId": "3806038dab03249b3040030b538ef01289dbd92e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
Loading…
Reference in New Issue