openstack
/
ovn-octavia-provider
Code Issues Proposed changes

tests: Remove obsolete TODO about a fd leak 

The warnings are no longer happening on main. I believe at one point in
time, Connection.stop() was mocked out while connection open was not.
Not anymore.

Change-Id: I87b917f0c4e5d607e37c780d8d3ce12beea6945b
This commit is contained in:
Ihar Hrachyshka 2024-05-14 10:07:14 -04:00
parent b0bfda27d0
commit 0cdc041566
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ovn_octavia_provider/tests/unit/ovsdb/test_impl_idl_ovn.py
View File

@ -36,11 +36,6 @@ class TestOvnNbIdlForLb(base.BaseTestCase):
def setUp(self):
super().setUp()
ovn_config.register_opts()
# TODO(haleyb) - figure out why every test in this class generates
# this warning, think it's in relation to reading this schema file:
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
# allocation traceback
self.mock_gsh = mock.patch.object(
idlutils, 'get_schema_helper',
side_effect=lambda x, y: ovs_idl.SchemaHelper(
@ -100,11 +95,6 @@ class TestOvnSbIdlForLb(base.BaseTestCase):
def setUp(self):
super().setUp()
ovn_config.register_opts()
# TODO(haleyb) - figure out why every test in this class generates
# this warning, think it's in relation to reading this schema file:
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
# allocation traceback
self.mock_gsh = mock.patch.object(
idlutils, 'get_schema_helper',
side_effect=lambda x, y: ovs_idl.SchemaHelper(