From 7a308a0f1373fa822fbd14029a8847e6ae150546 Mon Sep 17 00:00:00 2001 From: Sergey Vilgelm Date: Thu, 31 Jan 2019 10:32:15 -0600 Subject: [PATCH] Fix Policy action "get_flavors" not found The "get_flavors" policy has been removed since the Neutron uses policy in code. Patrole should test against the "get_flavor" policy and use the "override_role_and_validate_list" function for validation. Change-Id: Ibbe4e7e3dec27c56d4fd8990b77910866a694a3e --- .../tests/api/network/test_flavors_rbac.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/patrole_tempest_plugin/tests/api/network/test_flavors_rbac.py b/patrole_tempest_plugin/tests/api/network/test_flavors_rbac.py index 76c0db36..3b9a11f7 100644 --- a/patrole_tempest_plugin/tests/api/network/test_flavors_rbac.py +++ b/patrole_tempest_plugin/tests/api/network/test_flavors_rbac.py @@ -103,16 +103,18 @@ class FlavorsExtRbacTest(base.BaseNetworkExtRbacTest): @decorators.idempotent_id('ab10bd5d-987e-4255-966f-947670ffd0fa') @rbac_rule_validation.action(service="neutron", - rules=["get_flavors"]) + rules=["get_flavor"]) def test_list_flavors(self): """List flavors. - RBAC test for the neutron "get_flavors" policy + RBAC test for the neutron "get_flavor" policy for "list_flavors" action """ flavor = self.ntp_client.create_flavor(service_type=self.service_type) self.addCleanup( test_utils.call_and_ignore_notfound_exc, self.ntp_client.delete_flavor, flavor["flavor"]["id"]) - with self.rbac_utils.override_role(self): - self.ntp_client.list_flavors() + with self.rbac_utils.override_role_and_validate_list( + self, admin_resource_id=flavor["flavor"]["id"] + ) as ctx: + ctx.resources = self.ntp_client.list_flavors()['flavors']