Update patch set 2

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 6926 <6926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6926 2021-12-16 17:36:17 +00:00 committed by Gerrit Code Review
parent dc85a9965e
commit fd1fcfff15
1 changed files with 44 additions and 0 deletions

View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bba189db_9cf489f8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 6926
},
"writtenOn": "2021-12-16T17:36:17Z",
"side": 1,
"message": "well done, but a minor adjustment is required",
"revId": "52589b084c6da1ac764a03cf642f04629b6d8e96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bb1d65d2_8335deb0",
"filename": "paunch/utils/systemd.py",
"patchSetId": 2
},
"lineNbr": 173,
"author": {
"id": 6926
},
"writtenOn": "2021-12-16T17:36:17Z",
"side": 1,
"message": "these would not raise, but return False, if not enabled, neither active.\nplease also ad is_masked check to not return True for such a case",
"range": {
"startLine": 172,
"startChar": 0,
"endLine": 173,
"endChar": 35
},
"revId": "52589b084c6da1ac764a03cf642f04629b6d8e96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}