openstack
/
pbr
Code Issues Proposed changes

Clean up some style warnings 

ksh -n, weirdly enough, can be used as a rudimentary syntax and style
checker for bash. tools/integration.sh was mostly clean, but it
suggested that `` should be replaced with $(). Sure, why not.

Change-Id: I76beff1194133444284c1e8fbbd5d87db369e47f
This commit is contained in:
Monty Taylor 2013-08-03 18:51:33 -04:00
parent 5e281e4960
commit 51c9e626c6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/integration.sh
View File

@ -26,9 +26,9 @@ REPODIR=${REPODIR:-$BASE/new}
# TODO: Figure out how to get this on to the box properly
sudo apt-get install -y --force-yes libxml2-dev libxslt-dev libmysqlclient-dev libpq-dev libnspr4-dev pkg-config libsqlite3-dev libzmq-dev libffi-dev
tmpdir=`mktemp -d`
tmpdir=$(mktemp -d)
whoami=`whoami`
whoami=$(whoami)
tmpdownload=$tmpdir/download
mkdir -p $tmpdownload
@ -158,7 +158,7 @@ projectdir=$tmpdir/projects
mkdir -p $projectdir
for PROJECT in $PROJECTS ; do
SHORT_PROJECT=`basename $PROJECT`
SHORT_PROJECT=$(basename $PROJECT)
if ! grep 'pbr' $REPODIR/$SHORT_PROJECT/requirements.txt >/dev/null 2>&1
then
# project doesn't use pbr