tests: Restore - don't reset - warning filters
There are more various warning filters pre-configured in a typical Python environment, including a few from third-party libraries such as requests [1][2] and urllib3 [3] as well as stdlib [4]. Our fixture to configure warnings, 'WarningsFixture', called 'warnings.resetwarnings' which *reset* all the warning filters [5]. This is clearly not something we want to do, and resulted in tests puking warnings after the initial test run. Resolve this by backing up the existing warning filters before applying the filter, and then *restoring* this original list of warning filters after the test run. [1] https://github.com/psf/requests/blob/v2.26.0/requests/__init__.py#L127 [2] https://github.com/psf/requests/blob/v2.26.0/requests/__init__.py#L152 [3] https://github.com/urllib3/urllib3/blob/1.26.7/src/urllib3/__init__.py#L68-L78 [4] https://docs.python.org/3.8/library/warnings.html#default-warning-filter [5] https://docs.python.org/3.8/library/warnings.html#warnings.resetwarnings Change-Id: Ic5b0c723a6f02fce5bddbf0e4ac179dcfe62523a Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
parent
c68d472dca
commit
5a0f79827a
|
@ -70,6 +70,8 @@ class WarningsFixture(fixtures.Fixture):
|
|||
def setUp(self):
|
||||
super(WarningsFixture, self).setUp()
|
||||
|
||||
self._original_warning_filters = warnings.filters[:]
|
||||
|
||||
warnings.simplefilter("once", DeprecationWarning)
|
||||
|
||||
# Ignore policy scope warnings.
|
||||
|
@ -96,4 +98,7 @@ class WarningsFixture(fixtures.Fixture):
|
|||
message='Implicit coercion of SELECT and textual SELECT .*',
|
||||
category=sqla_exc.SADeprecationWarning)
|
||||
|
||||
self.addCleanup(warnings.resetwarnings)
|
||||
self.addCleanup(self._reset_warning_filters)
|
||||
|
||||
def _reset_warning_filters(self):
|
||||
warnings.filters[:] = self._original_warning_filters
|
||||
|
|
Loading…
Reference in New Issue