openstack
/
placement
Code Issues Proposed changes

Reduce max-complexity to 15 

The dependencies knock down the four most complex methods in the
project, bringing our most complex method to 14 (and hence our
max-complexity limit to 15).

Ife303d018a26ddcf8ea41d5950dc774c5e898a56
placement/util.py: 'parse_qs_request_groups' (17)

I9f3aa66b4806cf2c34f5271a5f4426839cb872ce
placement/objects/resource_provider.py:
  'ResourceProviderList._get_all_by_filters_from_db' (16)
placement/objects/resource_provider.py:
  '_get_provider_ids_matching' (16)

I80f8b1a74b8afdabbb85afc6caef1abef8ac3751
placement/objects/resource_provider.py:
  'AllocationCandidates._get_by_requests' (16)

Change-Id: I11d3e3c0e1baf729f2acceafbe2f115212a08385
This commit is contained in:
Eric Fried 2018-09-14 15:42:46 -06:00
parent 907a2cbecd
commit 7ddf015238
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tox.ini
View File

@ -193,8 +193,8 @@ ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405
exclude = .venv,.git,.tox,dist,*lib/python*,*egg,build,releasenotes
# To get a list of functions that have a complexity of 15 or more, set
# max-complexity to 15 and run 'tox -epep8'.
# 16 is currently the most complex thing we have
max-complexity=17
# 14 is currently the most complex thing we have
max-complexity=15
[hacking]
import_exceptions = placement.i18n