Implement gate-puppet-openstack-spec-helper-syntax

Create Implement gate-puppet-openstack-spec-helper-syntax (puppet 3 and 4)
that will run Puppet syntax tests against puppet-openstack_spec_helper,
like we already do with lint, unit and beaker.

Depends-On: Ia845567f5b3fa0c3e6c063126eddf95378708909
Change-Id: I6aca135e900a8aa2bed85a03ba06975317e216fe

jenkins/jobs/puppet-module-jobs.yaml

@@ -255,6 +255,35 @@
     publishers:
       - console-log
 
+- job-template:
+    name: 'gate-puppet-openstack-spec-helper-syntax-{puppet_version}-{node}'
+    node: '{node}'
+
+    builders:
+      - print-template-name:
+          template-name: "{template-name}"
+      - link-logs
+      - zuul-clone:
+          project: openstack/puppet-openstack_spec_helper
+      - install-distro-packages
+      - puppet-prepare-node
+      - shell: |
+          #!/bin/bash -xe
+          cd openstack/puppet-openstack_spec_helper
+          # FUTURE_PARSER=yes is only supported by Puppet 3.x
+          if [ "{puppet_version}" -lt "4" ]; then
+              export FUTURE_PARSER=yes
+          fi
+          ./run_syntax_tests.sh
+
+    wrappers:
+      - build-timeout:
+          timeout: 60
+      - timestamps
+
+    publishers:
+      - console-log
+
 - job-template:
     name: 'gate-puppet-openstack-spec-helper-unit-{node}'
     node: '{node}'
@@ -457,7 +486,11 @@
     name: 'puppet-openstack-spec-helper-jobs'
     node:
       - centos-7
+    puppet_version:
+      - 3
+      - 4
     jobs:
       - 'gate-puppet-openstack-spec-helper-lint-{node}'
+      - 'gate-puppet-openstack-spec-helper-syntax-{puppet_version}-{node}'
       - 'gate-puppet-openstack-spec-helper-unit-{node}'
       - 'gate-puppet-openstack-spec-helper-beaker-rspec-{node}'

zuul/layout.yaml

@@ -826,10 +826,14 @@ project-templates:
   - name: puppet-openstack-spec-helper-jobs
     check:
       - gate-puppet-openstack-spec-helper-lint-centos-7
+      - gate-puppet-openstack-spec-helper-syntax-3-centos-7
+      - gate-puppet-openstack-spec-helper-syntax-4-centos-7
       - gate-puppet-openstack-spec-helper-unit-centos-7
       - gate-puppet-openstack-spec-helper-beaker-rspec-centos-7
     gate:
       - gate-puppet-openstack-spec-helper-lint-centos-7
+      - gate-puppet-openstack-spec-helper-syntax-3-centos-7
+      - gate-puppet-openstack-spec-helper-syntax-4-centos-7
       - gate-puppet-openstack-spec-helper-unit-centos-7
       - gate-puppet-openstack-spec-helper-beaker-rspec-centos-7