From cfb30d3c41f962496137383dd78815704b5c1313 Mon Sep 17 00:00:00 2001 From: Erno Kuvaja Date: Thu, 29 Nov 2018 12:51:13 +0000 Subject: [PATCH] Add Review Priority column to glance repos This change adds review priority column to glance repos providing us tools to flag high priority reviews and block changes during freezes without needing to do it on the code review level. Change-Id: I3e73d2d4f40e2dbea5d1b723e8e12d719ba7413d --- gerrit/acls/openstack/glance.config | 13 +++++++++++++ gerrit/acls/openstack/glance_store.config | 13 +++++++++++++ gerrit/acls/openstack/python-glanceclient.config | 13 +++++++++++++ 3 files changed, 39 insertions(+) diff --git a/gerrit/acls/openstack/glance.config b/gerrit/acls/openstack/glance.config index 99b47f744c..b4cdfa6833 100644 --- a/gerrit/acls/openstack/glance.config +++ b/gerrit/acls/openstack/glance.config @@ -2,6 +2,7 @@ abandon = group glance-core abandon = group glance-reviewbot label-Code-Review = -2..+2 group glance-core +label-Review-Priority = -1..+2 group glance-core label-Workflow = -1..0 group glance-reviewbot label-Workflow = -1..+1 group glance-core @@ -20,6 +21,18 @@ label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group glance-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Top Priority / Holds Gate + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/glance_store.config b/gerrit/acls/openstack/glance_store.config index 56c672e912..2a9675b0e4 100644 --- a/gerrit/acls/openstack/glance_store.config +++ b/gerrit/acls/openstack/glance_store.config @@ -4,6 +4,7 @@ abandon = group glance-reviewbot abandon = group swift-core label-Code-Review = -2..+2 group glance-core label-Code-Review = -2..+2 group swift-core +label-Review-Priority = -1..+2 group glance-core label-Workflow = -1..0 group glance-reviewbot label-Workflow = -1..+0 group swift-core label-Workflow = -1..+1 group glance-core @@ -23,6 +24,18 @@ label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group glance-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Top Priority / Holds Gate + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/python-glanceclient.config b/gerrit/acls/openstack/python-glanceclient.config index 99b47f744c..b4cdfa6833 100644 --- a/gerrit/acls/openstack/python-glanceclient.config +++ b/gerrit/acls/openstack/python-glanceclient.config @@ -2,6 +2,7 @@ abandon = group glance-core abandon = group glance-reviewbot label-Code-Review = -2..+2 group glance-core +label-Review-Priority = -1..+2 group glance-core label-Workflow = -1..0 group glance-reviewbot label-Workflow = -1..+1 group glance-core @@ -20,6 +21,18 @@ label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group glance-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Top Priority / Holds Gate + [receive] requireChangeId = true requireContributorAgreement = true