openstack
/
project-team-guide
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+2

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 577406688fa6cfe73bb0edc987f3cacddd1054cb
This commit is contained in:
Gerrit User 8556 2024-01-12 17:23:03 +00:00 committed by Gerrit Code Review
parent 2c30b0b40b
commit 7edd66ee27
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
d15861b2ff7bac0fd8cd44228c8625977a4473f9
View File

@ -16,6 +16,46 @@
"message": "This is much more detailed and easier to follow - thanks!",
"revId": "d15861b2ff7bac0fd8cd44228c8625977a4473f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fb6ad79f_0f24130d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 8556
},
"writtenOn": "2024-01-12T17:23:03Z",
"side": 1,
"message": "lgtm, in addition, adding example can be easy to understand.",
"revId": "d15861b2ff7bac0fd8cd44228c8625977a4473f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "32a03f5d_b4bde710",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 159,
"author": {
"id": 8556
},
"writtenOn": "2024-01-12T17:23:03Z",
"side": 1,
"message": "looks good. if it is easy to understand the steps, please add any example also.",
"range": {
"startLine": 159,
"startChar": 27,
"endLine": 159,
"endChar": 28
},
"revId": "d15861b2ff7bac0fd8cd44228c8625977a4473f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}