Update patch set 1
Patch Set 1: Code-Review-1
(5 comments)
Patch-set: 1
Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 6077663795e295f26a7ed899f9e3ecfacfd4f4c7
Attention: {"person_ident":"Gerrit User 5314 \u003c5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
This commit is contained in:
Gerrit User 8556
Gerrit Code Review
parent
5e6937c72f
commit
a36b2971e1
|
|
@ -34,6 +34,69 @@
|
|||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "bc028403_a2063826",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 8556
|
||||
},
|
||||
"writtenOn": "2024-03-01T18:04:04Z",
|
||||
"side": 1,
|
||||
"message": "thanks Elod for adding it. a few suggestion but my -1 is mainly to cover the \u0027how to be added in PROJECTNAME-unmaintained-core\u0027 also.",
|
||||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e6d5f356_54abaf95",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 360,
|
||||
"author": {
|
||||
"id": 8556
|
||||
},
|
||||
"writtenOn": "2024-03-01T18:04:04Z",
|
||||
"side": 1,
|
||||
"message": "can we add a note about this group also the same way we did for global group?",
|
||||
"range": {
|
||||
"startLine": 360,
|
||||
"startChar": 12,
|
||||
"endLine": 360,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "cb431f6a_644d50c7",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 369,
|
||||
"author": {
|
||||
"id": 8556
|
||||
},
|
||||
"writtenOn": "2024-03-01T18:04:04Z",
|
||||
"side": 1,
|
||||
"message": "with ref to my above comment, can we make it generic for both group because both group exist and we should tell them how to become member in either one. Something like below\n\nTo become a member of the ``openstack-unmaintained-core`` or ``PROJECTNAME-unmaintained-core`` team,...",
|
||||
"range": {
|
||||
"startLine": 369,
|
||||
"startChar": 29,
|
||||
"endLine": 369,
|
||||
"endChar": 60
|
||||
},
|
||||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -158,6 +221,47 @@
|
|||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "692a5b2e_7d37bac0",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 371,
|
||||
"author": {
|
||||
"id": 8556
|
||||
},
|
||||
"writtenOn": "2024-03-01T18:04:04Z",
|
||||
"side": 1,
|
||||
"message": "I am not much in favor of defining a SIG which is again moving things under the upstream maintenance. We should keep \u0027unmaintained\u0027 process/branch/team as explicit different than what project/SIG team care of. That is why we have this group as explicit than the existing stable-core group.\n\nI will say to link the gerrit group here to know whom to contact for it https://review.opendev.org/admin/groups/4d728691952c04b8b2ec828eabc96b98dc124d69,members",
|
||||
"parentUuid": "3a76d643_dbe7d0a6",
|
||||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "07c8854f_bda9b24d",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 373,
|
||||
"author": {
|
||||
"id": 8556
|
||||
},
|
||||
"writtenOn": "2024-03-01T18:04:04Z",
|
||||
"side": 1,
|
||||
"message": "this was one of the confusion people had in discussion. What I understood from above paragraph as well this line that, member in global ``openstack-unmaintained-core`` or project specific ``PROJECTNAME-unmaintained-core`` group are responsible to maintain the CI (single or multiple projects) not just add/remove the members. Which is why encouraging \"member to be part of global group and if really needed then only create the project specific group\" make sense.\n\nso +1 on adding the CI maintenance responsibility explicitly here too.",
|
||||
"range": {
|
||||
"startLine": 373,
|
||||
"startChar": 48,
|
||||
"endLine": 373,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "8f25583cabd1424b9520efe29556e9c2b18c4fd3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue