From cbde626bb50ee6432c754ce4d1395d5782bbefc0 Mon Sep 17 00:00:00 2001 From: Zane Bitter Date: Mon, 18 Jun 2018 12:36:54 -0400 Subject: [PATCH] Clarify Code-Review 0 etiquette Make it clear that a submitter ignoring a comment with no vote on a review probably just missed it, and add contacting them on IRC as another technique for resolving any miscommunication. Change-Id: If63212b0b59e5da35d9029cfc0d8b0ac05d4c8f9 --- doc/source/review-the-openstack-way.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/source/review-the-openstack-way.rst b/doc/source/review-the-openstack-way.rst index 36b00f3..e4dac3b 100644 --- a/doc/source/review-the-openstack-way.rst +++ b/doc/source/review-the-openstack-way.rst @@ -79,9 +79,10 @@ You might leave a comment without a review if you don't have strong feelings either way about a change, or if you simply have a question you need answered in order to form an opinion. Unless you're fairly sure the answer to the question is going to reveal a problem, this is preferable to voting -1 in the -first instance. If it's been a while without an answer, or new patch sets are -posted without anyone responding to your comments, that might be time to -consider a -1. +first instance. Comments without -1 votes are easier to miss accidentally, so +if it's been a while without an answer, or new patch sets are posted without +anyone responding to your comments, that might be time to try contacting the +submitter on IRC or consider a -1 vote. .. _code-review-minus-1: