From 28c4efee3df8eb0e7688631fe74f1d75f162702a Mon Sep 17 00:00:00 2001 From: Guilherme Maluf Date: Mon, 12 Jun 2017 14:49:49 -0300 Subject: [PATCH] Set lowercase for ceph_config values Capitalized values of True and False are conflicting with systemd scripts This commit set all values to lowercase Fixes: Bug #1697476 Change-Id: Ibd01a7a850e7593fabd676b8b0c0af2b77101a2a --- lib/puppet/type/ceph_config.rb | 2 +- spec/unit/type/ceph_config_spec.rb | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/puppet/type/ceph_config.rb b/lib/puppet/type/ceph_config.rb index 5a44472d..6b36d3a8 100644 --- a/lib/puppet/type/ceph_config.rb +++ b/lib/puppet/type/ceph_config.rb @@ -42,7 +42,7 @@ Puppet::Type.newtype(:ceph_config) do desc 'The value of the setting to be defined.' munge do |value| value = value.to_s.strip - value.capitalize! if value =~ /^(true|false)$/i + value.downcase! if value =~ /^(true|false)$/i value end end diff --git a/spec/unit/type/ceph_config_spec.rb b/spec/unit/type/ceph_config_spec.rb index c78dfb68..b51ee8d1 100644 --- a/spec/unit/type/ceph_config_spec.rb +++ b/spec/unit/type/ceph_config_spec.rb @@ -29,13 +29,13 @@ describe 'Puppet::Type.type(:ceph_config)' do expect(@ceph_config[:value]).to eq('max') end - it 'should convert true to True' do + it 'should convert true to true' do @ceph_config[:value] = 'tRuE' - expect(@ceph_config[:value]).to eq('True') + expect(@ceph_config[:value]).to eq('true') end - it 'should convert false to False' do + it 'should convert false to false' do @ceph_config[:value] = 'fAlSe' - expect(@ceph_config[:value]).to eq('False') + expect(@ceph_config[:value]).to eq('false') end -end \ No newline at end of file +end