From 634b6152c185edc48b4bce6d38a68d6ee86afd9a Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Sun, 17 Mar 2024 16:15:51 +0900 Subject: [PATCH] nvmeof: Add reserved_percentage This defined resource type was overlooked when the reserved_percentage option was added[1]. [1] 5451b7135b486e8d7a8936adbc0f0d5298f5c3c3 Change-Id: I602f47cb06eff1c41b47abe36853bc418a122332 --- manifests/backend/nvmeof.pp | 6 ++++++ .../notes/nvmeof-reserved_percentage-4609d4aae48b5e37.yaml | 5 +++++ spec/defines/cinder_backend_nvmeof_spec.rb | 1 + 3 files changed, 12 insertions(+) create mode 100644 releasenotes/notes/nvmeof-reserved_percentage-4609d4aae48b5e37.yaml diff --git a/manifests/backend/nvmeof.pp b/manifests/backend/nvmeof.pp index a52e80eb..2e086c2e 100644 --- a/manifests/backend/nvmeof.pp +++ b/manifests/backend/nvmeof.pp @@ -50,6 +50,10 @@ # (Optional) Max number of entries allowed in the image volume cache. # Defaults to $facts['os_service_default'], # +# [*reserved_percentage*] +# (Optional) The percentage of backend capacity is reserved. +# Defaults to $facts['os_service_default']. +# # [*volume_driver*] # (Optional) Driver to use for volume creation # Defaults to 'cinder.volume.drivers.lvm.LVMVolumeDriver'. @@ -83,6 +87,7 @@ define cinder::backend::nvmeof ( $image_volume_cache_enabled = $facts['os_service_default'], $image_volume_cache_max_size_gb = $facts['os_service_default'], $image_volume_cache_max_count = $facts['os_service_default'], + $reserved_percentage = $facts['os_service_default'], $volume_driver = 'cinder.volume.drivers.lvm.LVMVolumeDriver', $volume_group = $facts['os_service_default'], $nvmeof_conn_info_version = $facts['os_service_default'], @@ -106,6 +111,7 @@ define cinder::backend::nvmeof ( "${name}/image_volume_cache_enabled": value => $image_volume_cache_enabled; "${name}/image_volume_cache_max_size_gb": value => $image_volume_cache_max_size_gb; "${name}/image_volume_cache_max_count": value => $image_volume_cache_max_count; + "${name}/reserved_percentage": value => $reserved_percentage; "${name}/volume_driver": value => $volume_driver; "${name}/volume_group": value => $volume_group; "${name}/nvmeof_conn_info_version": value => $nvmeof_conn_info_version; diff --git a/releasenotes/notes/nvmeof-reserved_percentage-4609d4aae48b5e37.yaml b/releasenotes/notes/nvmeof-reserved_percentage-4609d4aae48b5e37.yaml new file mode 100644 index 00000000..489fd5d7 --- /dev/null +++ b/releasenotes/notes/nvmeof-reserved_percentage-4609d4aae48b5e37.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + The ``cinder::backend::nvmeof::reserved_percentage`` parameter has been + added. diff --git a/spec/defines/cinder_backend_nvmeof_spec.rb b/spec/defines/cinder_backend_nvmeof_spec.rb index dc3678dc..391d24dc 100644 --- a/spec/defines/cinder_backend_nvmeof_spec.rb +++ b/spec/defines/cinder_backend_nvmeof_spec.rb @@ -29,6 +29,7 @@ describe 'cinder::backend::nvmeof' do is_expected.to contain_cinder_config('nvme-backend/image_volume_cache_enabled').with_value('') is_expected.to contain_cinder_config('nvme-backend/image_volume_cache_max_size_gb').with_value('') is_expected.to contain_cinder_config('nvme-backend/image_volume_cache_max_count').with_value('') + is_expected.to contain_cinder_config('nvme-backend/reserved_percentage').with_value('') is_expected.to contain_cinder_config('nvme-backend/volume_driver').with_value('cinder.volume.drivers.lvm.LVMVolumeDriver') is_expected.to contain_cinder_config('nvme-backend/nvmeof_conn_info_version').with_value('') is_expected.to contain_cinder_config('nvme-backend/lvm_share_target').with_value('')