openstack
/
puppet-cinder
Code Issues Proposed changes

Add use_journal option for logging configuration 

This enables oslo.log to pass logging records to journald.

Change-Id: I8c1e17cc85c5c3491936b07cff566e810f7f860c
This commit is contained in:
ZhongShengping 2018-01-15 15:30:08 +08:00
parent f59554ff4f
commit f763d7e94d
3 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/logging.pp
View File

@ -14,7 +14,11 @@
# [*use_json*]
# (Optional) Use json for logging.
# Defaults to $::os_service_default
#
# [*use_journal*]
# (Optional) Use journal for logging.
# Defaults to $::os_service_default
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to $::os_service_default
@ -92,6 +96,7 @@
class cinder::logging(
$use_syslog = $::os_service_default,
$use_json = $::os_service_default,
$use_journal = $::os_service_default,
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/cinder',
@ -127,6 +132,7 @@ class cinder::logging(
debug => $debug_real,
use_syslog => $use_syslog_real,
use_json => $use_json,
use_journal => $use_journal,
use_stderr => $use_stderr_real,
log_dir => $log_dir_real,
syslog_log_facility => $log_facility_real,

5
releasenotes/notes/add-use_journal-option-for-logging-b58b64d730051e28.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Adds the use_journal option for configuring oslo.log. This will enable
passing the logs to journald.

13
spec/classes/cinder_logging_spec.rb
View File

@ -25,6 +25,7 @@ describe 'cinder::logging' do
:log_date_format => '%Y-%m-%d %H:%M:%S',
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
@ -57,11 +58,12 @@ describe 'cinder::logging' do
shared_examples 'basic default logging settings' do
it 'configures cinder logging settings with default values' do
is_expected.to contain_oslo__log('cinder_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/cinder',
:debug => '<SERVICE DEFAULT>',
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_journal => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/cinder',
:debug => '<SERVICE DEFAULT>',
)
end
end
@ -71,6 +73,7 @@ describe 'cinder::logging' do
is_expected.to contain_oslo__log('cinder_config').with(
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',