openstack
/
puppet-cloudkitty
Code Issues Proposed changes

[orchestrator] coordination_url should be hidden 

The coordination_url option can sometimes contain secrets.

For example when redis coordination backend is used and authentication
is enabled in redis, the plain redis password is put as an URL element.

[orchestrator]
coordination_url=redis://:password@127.0.0.1:6379

Closes-Bug: #2012246
Change-Id: Iba1e7715b290ee4c104f11221e250b23936b12dc
This commit is contained in:
Takashi Kajinami 2023-03-20 21:11:32 +09:00
parent 25e2da3b42
commit 70d66f8f55
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/orchestrator.pp
View File

@ -32,7 +32,7 @@ class cloudkitty::orchestrator (
}
cloudkitty_config {
'orchestrator/coordination_url': value => $coordination_url;
'orchestrator/coordination_url': value => $coordination_url, secret => true;
'orchestrator/max_workers': value => $max_workers_real;
'orchestrator/max_threads': value => $max_threads;
}

4
spec/classes/cloudkitty_orchestrator_spec.rb
View File

@ -9,7 +9,7 @@ describe 'cloudkitty::orchestrator' do
it 'configures orchestrator' do
is_expected.to contain_cloudkitty_config('orchestrator/coordination_url')\
.with_value('<SERVICE DEFAULT>')
.with_value('<SERVICE DEFAULT>').with_secret(true)
is_expected.to contain_oslo__coordination('cloudkitty_config').with(
:backend_url => '<SERVICE DEFAULT>',
:manage_config => false,
@ -30,7 +30,7 @@ describe 'cloudkitty::orchestrator' do
it 'configures orchestrator' do
is_expected.to contain_cloudkitty_config('orchestrator/coordination_url')\
.with_value('etcd3+http://127.0.0.1:2379')
.with_value('etcd3+http://127.0.0.1:2379').with_secret(true)
is_expected.to contain_oslo__coordination('cloudkitty_config').with(
:backend_url => 'etcd3+http://127.0.0.1:2379',
:manage_config => false,