From a45b62e2139941c49e7079968793965108abc6b3 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Sun, 28 Aug 2022 23:00:14 +0900
Subject: [PATCH] Remove deprecated behavior of enabled_notification_handlers

Handling of a false value was deprecated during Yoga cycle[1].

[1] f87bd126b0247112e3c130e1397484ba17b5647f

Change-Id: I9d96ba4bf12dd4c093aba55d7916598ff24f3327
---
 manifests/sink.pp                                      | 10 +---------
 ...enabled_notification_handlers-442dde7d553c41b9.yaml |  6 ++++++
 2 files changed, 7 insertions(+), 9 deletions(-)
 create mode 100644 releasenotes/notes/cleanup-enabled_notification_handlers-442dde7d553c41b9.yaml

diff --git a/manifests/sink.pp b/manifests/sink.pp
index 389fc213..aee33f11 100644
--- a/manifests/sink.pp
+++ b/manifests/sink.pp
@@ -59,15 +59,7 @@ class designate::sink (
     'service:sink/threads': value => $threads;
   }
 
-  if ! $enabled_notification_handlers {
-    warning('Usage of false value for enabled_notification_handlers is deprecated. \
-Use $::os_service_default instead')
-    $enabled_notification_handlers_real = $::os_service_default
-  } else {
-    $enabled_notification_handlers_real = $enabled_notification_handlers
-  }
-
   designate_config {
-    'service:sink/enabled_notification_handlers': value => join(any2array($enabled_notification_handlers_real), ',')
+    'service:sink/enabled_notification_handlers': value => join(any2array($enabled_notification_handlers), ',')
   }
 }
diff --git a/releasenotes/notes/cleanup-enabled_notification_handlers-442dde7d553c41b9.yaml b/releasenotes/notes/cleanup-enabled_notification_handlers-442dde7d553c41b9.yaml
new file mode 100644
index 00000000..36bc9ca7
--- /dev/null
+++ b/releasenotes/notes/cleanup-enabled_notification_handlers-442dde7d553c41b9.yaml
@@ -0,0 +1,6 @@
+---
+upgrade:
+  - |
+    The ``designate::sink::enabled_notification_handlers`` parameter no longer
+    treats a false value to unset the parameter. Use ``$::os_service_default``
+    instead of the service default should be used.