From 4bccd3397446e9b10931e36826e0f3c2665cf362 Mon Sep 17 00:00:00 2001
From: ZhongShengping <chdzsp@163.com>
Date: Tue, 12 Mar 2019 10:37:37 +0800
Subject: [PATCH] Add log_file parameter

Change-Id: Ice3b3565ef018a93aa7085beecf7b245b25e838b
Closes-Bug: #1819417
---
 manifests/logging.pp                                        | 6 ++++++
 .../notes/add-log_file-for-logging-9a3077e21772e3f0.yaml    | 4 ++++
 spec/classes/designate_logging_spec.rb                      | 3 +++
 3 files changed, 13 insertions(+)
 create mode 100644 releasenotes/notes/add-log_file-for-logging-9a3077e21772e3f0.yaml

diff --git a/manifests/logging.pp b/manifests/logging.pp
index 10600448..e3fd5bf1 100644
--- a/manifests/logging.pp
+++ b/manifests/logging.pp
@@ -33,6 +33,10 @@
 #   If set to $::os_service_default, it will not log to any directory.
 #   Defaults to $::designate::params::log_dir
 #
+# [*log_file*]
+#   (Optional) File where logs should be stored.
+#   Defaults to $::os_service_default
+#
 # [*logging_context_format_string*]
 #   (Optional) Format string to use for log messages with context.
 #   Defaults to $::os_service_default
@@ -100,6 +104,7 @@ class designate::logging(
   $use_stderr                    = $::os_service_default,
   $log_facility                  = $::os_service_default,
   $log_dir                       = $::designate::params::log_dir,
+  $log_file                      = $::os_service_default,
   $debug                         = $::os_service_default,
   $logging_context_format_string = $::os_service_default,
   $logging_default_format_string = $::os_service_default,
@@ -123,6 +128,7 @@ class designate::logging(
     use_journal                   => $use_journal,
     use_stderr                    => $use_stderr,
     log_dir                       => $log_dir,
+    log_file                      => $log_file,
     syslog_log_facility           => $log_facility,
     logging_context_format_string => $logging_context_format_string,
     logging_default_format_string => $logging_default_format_string,
diff --git a/releasenotes/notes/add-log_file-for-logging-9a3077e21772e3f0.yaml b/releasenotes/notes/add-log_file-for-logging-9a3077e21772e3f0.yaml
new file mode 100644
index 00000000..e40d4c81
--- /dev/null
+++ b/releasenotes/notes/add-log_file-for-logging-9a3077e21772e3f0.yaml
@@ -0,0 +1,4 @@
+---
+features:
+  - |
+    Add the log_file option for logging.
diff --git a/spec/classes/designate_logging_spec.rb b/spec/classes/designate_logging_spec.rb
index 38a642fa..353393c8 100644
--- a/spec/classes/designate_logging_spec.rb
+++ b/spec/classes/designate_logging_spec.rb
@@ -29,6 +29,7 @@ describe 'designate::logging' do
      :use_stderr                     => false,
      :log_facility                   => 'LOG_FOO',
      :log_dir                        => '/var/log',
+     :log_file                       => '/var/log/designate/designate.log',
      :debug                          => true,
     }
   end
@@ -64,6 +65,7 @@ describe 'designate::logging' do
         :use_stderr          => '<SERVICE DEFAULT>',
         :syslog_log_facility => '<SERVICE DEFAULT>',
         :log_dir             => '/var/log/designate',
+        :log_file               => '<SERVICE DEFAULT>',
         :debug               => '<SERVICE DEFAULT>',
       )
     end
@@ -78,6 +80,7 @@ describe 'designate::logging' do
         :use_stderr          => false,
         :syslog_log_facility => 'LOG_FOO',
         :log_dir             => '/var/log',
+        :log_file            => '/var/log/designate/designate.log',
         :debug               => true,
       )
     end