Deprecate disabling UEFI support for inspection

We only did that because our repositories didn't have necessary firmware
files. Not it seems like all distros ship them, there is no point in disabling
UEFI support.

Change-Id: I0f242a7e1c28c4007b3c2d955dbd3b29086e92f1

manifests/inspector.pp

@@ -34,10 +34,6 @@
 #  (optional) Protocol to be used for transferring the ramdisk
 #  Defaults to 'tftp'. Valid values are 'tftp' or 'http'.
 #
-# [*enable_uefi*]
-# (optional) Allow introspection of machines with UEFI firmware.
-# Defaults to false. Ignored unless $pxe_transfer_protocol='http'.
-#
 # [*debug*]
 #   (optional) Enable debug logging
 #   Defaults to undef
@@ -163,12 +159,19 @@
 #   (optional) Whether to store the boot mode (BIOS or UEFI).
 #   Defaults to $::os_service_default
 #
+# DEPRECATED
+#
+# [*enable_uefi*]
+#  (optional) Allow introspection of machines with UEFI firmware.
+#  This parameter is deprecated and will be removed. UEFI will always be
+#  enabled. Ignored unless $pxe_transfer_protocol='http'.
+#  Defaults to false.
+#
 class ironic::inspector (
   $package_ensure                  = 'present',
   $enabled                         = true,
   $listen_address                  = $::os_service_default,
   $pxe_transfer_protocol           = 'tftp',
-  $enable_uefi                     = false,
   $debug                           = undef,
   $auth_strategy                   = 'keystone',
   $dnsmasq_interface               = 'br-ctlplane',
@@ -200,6 +203,8 @@ class ironic::inspector (
   $detect_boot_mode                = $::os_service_default,
   $tftp_root                       = '/tftpboot',
   $http_root                       = '/httpboot',
+  # DEPRECATED
+  $enable_uefi                     = undef,
 ) {
 
   include ::ironic::deps
@@ -212,6 +217,12 @@ class ironic::inspector (
     include ::ironic::inspector::authtoken
   }
 
+  if $enable_uefi == undef {
+    warning('UEFI will be enabled by default starting with Pike')
+  } else {
+    warning('enable_uefi is deprecated and will be hardcoded to true in Pike')
+  }
+
   warning("After Newton cycle ::ironic::inspector won't provide \
 tftpboot and httpboot setup, please include ::ironic::pxe")
 

releasenotes/notes/no-disable-uefi-a143b0b143d0b1db.yaml

@@ -0,0 +1,4 @@
+---
+deprecations:
+  - Ability to disable UEFI support for inspection via "enable_uefi" parameter
+    is deprecated. This option will be removed in the future.