diff --git a/manifests/params.pp b/manifests/params.pp index 9c179d28..a4c964a7 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -22,18 +22,15 @@ class ironic::params { include ::openstacklib::defaults + $pyvers = $::openstacklib::defaults::pyvers + $pyver3 = $::openstacklib::defaults::pyver3 + if ($::os_package_type == 'debian') { - $pyvers = '3' - $pyver3 = '3' $syslinux_path_custom = '/usr/lib/syslinux' } elsif ($::os['name'] == 'Fedora') or ($::os['family'] == 'RedHat' and Integer.new($::os['release']['major']) > 7) { - $pyvers = '3' - $pyver3 = '3.6' $syslinux_path_custom = '/tftpboot' } else { - $pyvers = '' - $pyver3 = '2.7' $syslinux_path_custom = '/var/lib/tftpboot' } diff --git a/spec/classes/ironic_client_spec.rb b/spec/classes/ironic_client_spec.rb index c3e272a4..6d3d8c9d 100644 --- a/spec/classes/ironic_client_spec.rb +++ b/spec/classes/ironic_client_spec.rb @@ -47,11 +47,7 @@ describe 'ironic::client' do let(:platform_params) do case facts[:osfamily] when 'Debian' - if facts[:os_package_type] == 'debian' - { :client_package_name => 'python3-ironicclient' } - else - { :client_package_name => 'python-ironicclient' } - end + { :client_package_name => 'python3-ironicclient' } when 'RedHat' { :client_package_name => 'python-ironicclient' } end diff --git a/spec/classes/ironic_drivers_drac_spec.rb b/spec/classes/ironic_drivers_drac_spec.rb index 1c4838fb..7a1000c4 100644 --- a/spec/classes/ironic_drivers_drac_spec.rb +++ b/spec/classes/ironic_drivers_drac_spec.rb @@ -26,7 +26,7 @@ describe 'ironic::drivers::drac' do it 'installs dracclient package' do is_expected.to contain_package('python-dracclient').with( :ensure => 'present', - :name => 'python-dracclient', + :name => platform_params[:dracclient_package_name], :tag => ['openstack', 'ironic-package'], ) end @@ -40,6 +40,16 @@ describe 'ironic::drivers::drac' do let (:facts) do facts.merge!(OSDefaults.get_facts()) end + + let (:platform_params) do + case facts[:osfamily] + when 'Debian' + { :dracclient_package_name => 'python3-dracclient' } + when 'RedHat' + { :dracclient_package_name => 'python-dracclient' } + end + end + it_behaves_like 'ironic drac driver' end end diff --git a/spec/classes/ironic_drivers_ilo_spec.rb b/spec/classes/ironic_drivers_ilo_spec.rb index 1cfc0f94..977cdc13 100644 --- a/spec/classes/ironic_drivers_ilo_spec.rb +++ b/spec/classes/ironic_drivers_ilo_spec.rb @@ -36,7 +36,7 @@ describe 'ironic::drivers::ilo' do it 'installs proliantutils package' do is_expected.to contain_package('python-proliantutils').with( :ensure => 'present', - :name => 'python-proliantutils', + :name => platform_params[:proliantutils_package_name], :tag => ['openstack', 'ironic-package'], ) end @@ -65,6 +65,16 @@ describe 'ironic::drivers::ilo' do let (:facts) do facts.merge!(OSDefaults.get_facts()) end + + let (:platform_params) do + case facts[:osfamily] + when 'Debian' + { :proliantutils_package_name => 'python3-proliantutils' } + when 'RedHat' + { :proliantutils_package_name => 'python-proliantutils' } + end + end + it_behaves_like 'ironic ilo driver' end end diff --git a/spec/classes/ironic_drivers_redfish_spec.rb b/spec/classes/ironic_drivers_redfish_spec.rb index b000d8ac..d39a00e4 100644 --- a/spec/classes/ironic_drivers_redfish_spec.rb +++ b/spec/classes/ironic_drivers_redfish_spec.rb @@ -34,7 +34,7 @@ describe 'ironic::drivers::redfish' do it 'installs sushy package' do is_expected.to contain_package('python-sushy').with( :ensure => 'present', - :name => 'python-sushy', + :name => platform_params[:sushy_package_name], :tag => ['openstack', 'ironic-package'], ) end @@ -59,6 +59,16 @@ describe 'ironic::drivers::redfish' do let (:facts) do facts.merge!(OSDefaults.get_facts()) end + + let (:platform_params) do + case facts[:osfamily] + when 'Debian' + { :sushy_package_name => 'python3-sushy' } + when 'RedHat' + { :sushy_package_name => 'python-sushy' } + end + end + it_behaves_like 'ironic redfish driver' end end diff --git a/spec/classes/ironic_init_spec.rb b/spec/classes/ironic_init_spec.rb index 1fe1b69e..7cb68f09 100644 --- a/spec/classes/ironic_init_spec.rb +++ b/spec/classes/ironic_init_spec.rb @@ -262,13 +262,8 @@ describe 'ironic' do let :platform_params do case facts[:osfamily] when 'Debian' - if facts[:os_package_type] == 'debian' then - ironic_lib_pkgname = 'python3-ironic-lib' - else - ironic_lib_pkgname = 'python-ironic-lib' - end { :common_package_name => 'ironic-common', - :lib_package_name => ironic_lib_pkgname } + :lib_package_name => 'python3-ironic-lib' } when 'RedHat' { :common_package_name => 'openstack-ironic-common', :lib_package_name => 'python-ironic-lib' } diff --git a/spec/classes/ironic_inspector_client_spec.rb b/spec/classes/ironic_inspector_client_spec.rb index 781149be..7b6b9716 100644 --- a/spec/classes/ironic_inspector_client_spec.rb +++ b/spec/classes/ironic_inspector_client_spec.rb @@ -35,7 +35,7 @@ describe 'ironic::inspector::client' do it 'installs ironic inspector client package' do is_expected.to contain_package('python-ironic-inspector-client').with( :ensure => 'present', - :name => 'python-ironic-inspector-client', + :name => platform_params[:ironic_inspector_client_package_name], :tag => ['openstack', 'ironic-support-package'], ) end @@ -49,6 +49,15 @@ describe 'ironic::inspector::client' do facts.merge!(OSDefaults.get_facts()) end + let (:platform_params) do + case facts[:osfamily] + when 'Debian' + { :ironic_inspector_client_package_name => 'python3-ironic-inspector-client' } + when 'RedHat' + { :ironic_inspector_client_package_name => 'python-ironic-inspector-client' } + end + end + it_configures 'inspector client' end end diff --git a/spec/classes/ironic_wsgi_apache_spec.rb b/spec/classes/ironic_wsgi_apache_spec.rb index 4c15b2a8..d3d7cae9 100644 --- a/spec/classes/ironic_wsgi_apache_spec.rb +++ b/spec/classes/ironic_wsgi_apache_spec.rb @@ -94,7 +94,7 @@ describe 'ironic::wsgi::apache' do :httpd_service_name => 'apache2', :httpd_ports_file => '/etc/apache2/ports.conf', :wsgi_script_path => '/usr/lib/cgi-bin/ironic', - :wsgi_script_source => '/usr/lib/python2.7/dist-packages/ironic/api/app.wsgi', + :wsgi_script_source => '/usr/lib/python3/dist-packages/ironic/api/app.wsgi', } when 'RedHat' {