From 0a7a6b0ef0a5a2a3c38020643b7681b672cd276c Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Wed, 17 Jan 2024 15:31:47 +0900 Subject: [PATCH] healthcheck: Expose allowed_source_ranges ... which was added to puppet-oslo recently. Depends-on: https://review.opendev.org/905557 Change-Id: I667e583b9b6617ac57a22f340c8d3d4027d6d23c --- manifests/healthcheck.pp | 7 +++++++ ...healthcheck-allowed_source_ranges-c701ad7f2df78486.yaml | 5 +++++ spec/classes/magnum_healthcheck_spec.rb | 3 +++ 3 files changed, 15 insertions(+) create mode 100644 releasenotes/notes/healthcheck-allowed_source_ranges-c701ad7f2df78486.yaml diff --git a/manifests/healthcheck.pp b/manifests/healthcheck.pp index 6d68b22..d6787ec 100644 --- a/manifests/healthcheck.pp +++ b/manifests/healthcheck.pp @@ -13,6 +13,11 @@ # that information back as part of a request. # Defaults to $facts['os_service_default'] # +# [*allowed_source_ranges*] +# (Optional) A list of network addresses to limit source ip allowed to access +# healthcheck information. +# Defaults to $facts['os_service_default'] +# # [*disable_by_file_path*] # (Optional) Check the presence of a file to determine if an application # is running on a port. @@ -26,6 +31,7 @@ class magnum::healthcheck ( $detailed = $facts['os_service_default'], $backends = $facts['os_service_default'], + $allowed_source_ranges = $facts['os_service_default'], $disable_by_file_path = $facts['os_service_default'], $disable_by_file_paths = $facts['os_service_default'], ) { @@ -35,6 +41,7 @@ class magnum::healthcheck ( oslo::healthcheck { 'magnum_config': detailed => $detailed, backends => $backends, + allowed_source_ranges => $allowed_source_ranges, disable_by_file_path => $disable_by_file_path, disable_by_file_paths => $disable_by_file_paths, } diff --git a/releasenotes/notes/healthcheck-allowed_source_ranges-c701ad7f2df78486.yaml b/releasenotes/notes/healthcheck-allowed_source_ranges-c701ad7f2df78486.yaml new file mode 100644 index 0000000..b43f18f --- /dev/null +++ b/releasenotes/notes/healthcheck-allowed_source_ranges-c701ad7f2df78486.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + The new ``magnum::healthcheck::allowed_source_ranges`` parameter has been + added. diff --git a/spec/classes/magnum_healthcheck_spec.rb b/spec/classes/magnum_healthcheck_spec.rb index ed68ecf..8394be6 100644 --- a/spec/classes/magnum_healthcheck_spec.rb +++ b/spec/classes/magnum_healthcheck_spec.rb @@ -13,6 +13,7 @@ describe 'magnum::healthcheck' do is_expected.to contain_oslo__healthcheck('magnum_config').with( :detailed => '', :backends => '', + :allowed_source_ranges => '', :disable_by_file_path => '', :disable_by_file_paths => '', ) @@ -24,6 +25,7 @@ describe 'magnum::healthcheck' do { :detailed => true, :backends => ['disable_by_file'], + :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], :disable_by_file_path => '/etc/magnum/healthcheck/disabled', :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], } @@ -33,6 +35,7 @@ describe 'magnum::healthcheck' do is_expected.to contain_oslo__healthcheck('magnum_config').with( :detailed => true, :backends => ['disable_by_file'], + :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], :disable_by_file_path => '/etc/magnum/healthcheck/disabled', :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], )