diff --git a/manifests/healthcheck.pp b/manifests/healthcheck.pp index d6787ec..07af7e9 100644 --- a/manifests/healthcheck.pp +++ b/manifests/healthcheck.pp @@ -18,6 +18,10 @@ # healthcheck information. # Defaults to $facts['os_service_default'] # +# [*ignore_proxied_requests*] +# (Optional) Ignore requests with proxy headers +# Defaults to $facts['os_service_default'] +# # [*disable_by_file_path*] # (Optional) Check the presence of a file to determine if an application # is running on a port. @@ -29,20 +33,22 @@ # Defaults to $facts['os_service_default'] # class magnum::healthcheck ( - $detailed = $facts['os_service_default'], - $backends = $facts['os_service_default'], - $allowed_source_ranges = $facts['os_service_default'], - $disable_by_file_path = $facts['os_service_default'], - $disable_by_file_paths = $facts['os_service_default'], + $detailed = $facts['os_service_default'], + $backends = $facts['os_service_default'], + $allowed_source_ranges = $facts['os_service_default'], + $ignore_proxied_requests = $facts['os_service_default'], + $disable_by_file_path = $facts['os_service_default'], + $disable_by_file_paths = $facts['os_service_default'], ) { include magnum::deps oslo::healthcheck { 'magnum_config': - detailed => $detailed, - backends => $backends, - allowed_source_ranges => $allowed_source_ranges, - disable_by_file_path => $disable_by_file_path, - disable_by_file_paths => $disable_by_file_paths, + detailed => $detailed, + backends => $backends, + allowed_source_ranges => $allowed_source_ranges, + ignore_proxied_requests => $ignore_proxied_requests, + disable_by_file_path => $disable_by_file_path, + disable_by_file_paths => $disable_by_file_paths, } } diff --git a/releasenotes/notes/healthcheck-ignore_proxied_requests-2f066635a5378111.yaml b/releasenotes/notes/healthcheck-ignore_proxied_requests-2f066635a5378111.yaml new file mode 100644 index 0000000..6204d68 --- /dev/null +++ b/releasenotes/notes/healthcheck-ignore_proxied_requests-2f066635a5378111.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + The new ``magnum::healthcheck::ignore_proxied_requests`` parameter has been + added. diff --git a/spec/classes/magnum_healthcheck_spec.rb b/spec/classes/magnum_healthcheck_spec.rb index 8394be6..bcf9b3d 100644 --- a/spec/classes/magnum_healthcheck_spec.rb +++ b/spec/classes/magnum_healthcheck_spec.rb @@ -11,11 +11,12 @@ describe 'magnum::healthcheck' do it 'configures default values' do is_expected.to contain_oslo__healthcheck('magnum_config').with( - :detailed => '', - :backends => '', - :allowed_source_ranges => '', - :disable_by_file_path => '', - :disable_by_file_paths => '', + :detailed => '', + :backends => '', + :allowed_source_ranges => '', + :ignore_proxied_requests => '', + :disable_by_file_path => '', + :disable_by_file_paths => '', ) end end @@ -23,21 +24,23 @@ describe 'magnum::healthcheck' do context 'with specific parameters' do let :params do { - :detailed => true, - :backends => ['disable_by_file'], - :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], - :disable_by_file_path => '/etc/magnum/healthcheck/disabled', - :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], + :detailed => true, + :backends => ['disable_by_file'], + :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], + :ignore_proxied_requests => false, + :disable_by_file_path => '/etc/magnum/healthcheck/disabled', + :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], } end it 'configures specified values' do is_expected.to contain_oslo__healthcheck('magnum_config').with( - :detailed => true, - :backends => ['disable_by_file'], - :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], - :disable_by_file_path => '/etc/magnum/healthcheck/disabled', - :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], + :detailed => true, + :backends => ['disable_by_file'], + :allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'], + :ignore_proxied_requests => false, + :disable_by_file_path => '/etc/magnum/healthcheck/disabled', + :disable_by_file_paths => ['9511:/etc/magnum/healthcheck/disabled'], ) end end