From 4c6eb6ad9a95cfb2ca81f3dae88c0cc2e5b9f8ba Mon Sep 17 00:00:00 2001
From: ZhongShengping <chdzsp@163.com>
Date: Wed, 28 Dec 2016 14:14:53 +0800
Subject: [PATCH] Deprecate signing_dir option

The signing_dir is deprecated for removel because of PKI token format
is no longer supported.
Update warning message and release note.

Change-Id: Ib747adfa6b49b8b57f53ffaf374618cf3c5b32db
Closes-Bug: #1652700
---
 manifests/keystone/authtoken.pp                | 18 ++++++++++++------
 ...signing_dir_parameter-3491335a3f8135ef.yaml |  4 ++++
 spec/classes/manila_keystone_authtoken_spec.rb |  3 ---
 3 files changed, 16 insertions(+), 9 deletions(-)
 create mode 100644 releasenotes/notes/deprecate_signing_dir_parameter-3491335a3f8135ef.yaml

diff --git a/manifests/keystone/authtoken.pp b/manifests/keystone/authtoken.pp
index 60675591..67d11e60 100644
--- a/manifests/keystone/authtoken.pp
+++ b/manifests/keystone/authtoken.pp
@@ -175,16 +175,18 @@
 #   reduce performance. Only valid for PKI tokens. Integer value
 #   Defaults to $::os_service_default.
 #
-# [*signing_dir*]
-#   (Optional) Directory used to cache files related to PKI tokens.
-#   Defaults to $::os_service_default.
-#
 # [*token_cache_time*]
 #   (Optional) In order to prevent excessive effort spent validating tokens,
 #   the middleware caches previously-seen tokens for a configurable duration
 #   (in seconds). Set to -1 to disable caching completely. Integer value
 #   Defaults to $::os_service_default.
 #
+# DEPRECATED PARAMETERS
+#
+# [*signing_dir*]
+#   (Optional) Directory used to cache files related to PKI tokens.
+#   Defaults to undef
+#
 class manila::keystone::authtoken(
   $password                       = $::os_service_default,
   $username                       = 'manila',
@@ -219,14 +221,19 @@ class manila::keystone::authtoken(
   $memcached_servers              = $::os_service_default,
   $region_name                    = $::os_service_default,
   $revocation_cache_time          = $::os_service_default,
-  $signing_dir                    = $::os_service_default,
   $token_cache_time               = $::os_service_default,
+  # DEPRECATED PARAMETERS
+  $signing_dir                    = undef,
 ) {
 
   if is_service_default($password) {
     fail('Please set password for manila service user')
   }
 
+  if $signing_dir {
+    warning('signing_dir parameter is deprecated, has no effect and will be removed in the P release.')
+  }
+
   keystone::resource::authtoken { 'manila_config':
     username                       => $username,
     password                       => $password,
@@ -261,7 +268,6 @@ class manila::keystone::authtoken(
     memcached_servers              => $memcached_servers,
     region_name                    => $region_name,
     revocation_cache_time          => $revocation_cache_time,
-    signing_dir                    => $signing_dir,
     token_cache_time               => $token_cache_time,
   }
 }
diff --git a/releasenotes/notes/deprecate_signing_dir_parameter-3491335a3f8135ef.yaml b/releasenotes/notes/deprecate_signing_dir_parameter-3491335a3f8135ef.yaml
new file mode 100644
index 00000000..9c3ade95
--- /dev/null
+++ b/releasenotes/notes/deprecate_signing_dir_parameter-3491335a3f8135ef.yaml
@@ -0,0 +1,4 @@
+---
+deprecations:
+  - signing_dir option is now deprecated for removal, the
+    parameter has no effect.
diff --git a/spec/classes/manila_keystone_authtoken_spec.rb b/spec/classes/manila_keystone_authtoken_spec.rb
index 722c1fd6..c226202f 100644
--- a/spec/classes/manila_keystone_authtoken_spec.rb
+++ b/spec/classes/manila_keystone_authtoken_spec.rb
@@ -49,7 +49,6 @@ describe 'manila::keystone::authtoken' do
         is_expected.to contain_manila_config('keystone_authtoken/memcached_servers').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_manila_config('keystone_authtoken/region_name').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_manila_config('keystone_authtoken/revocation_cache_time').with_value('<SERVICE DEFAULT>')
-        is_expected.to contain_manila_config('keystone_authtoken/signing_dir').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_manila_config('keystone_authtoken/token_cache_time').with_value('<SERVICE DEFAULT>')
       end
     end
@@ -90,7 +89,6 @@ describe 'manila::keystone::authtoken' do
           :memcached_servers                    => ['memcached01:11211','memcached02:11211'],
           :region_name                          => 'region2',
           :revocation_cache_time                => '11',
-          :signing_dir                          => '/var/cache',
           :token_cache_time                     => '301',
         })
       end
@@ -129,7 +127,6 @@ describe 'manila::keystone::authtoken' do
         is_expected.to contain_manila_config('keystone_authtoken/memcached_servers').with_value('memcached01:11211,memcached02:11211')
         is_expected.to contain_manila_config('keystone_authtoken/region_name').with_value(params[:region_name])
         is_expected.to contain_manila_config('keystone_authtoken/revocation_cache_time').with_value(params[:revocation_cache_time])
-        is_expected.to contain_manila_config('keystone_authtoken/signing_dir').with_value(params[:signing_dir])
         is_expected.to contain_manila_config('keystone_authtoken/token_cache_time').with_value(params[:token_cache_time])
       end
     end