From 5624001fbcf1ee7264062f08c57daf254243f010 Mon Sep 17 00:00:00 2001 From: ZhongShengping Date: Mon, 15 Jan 2018 15:56:02 +0800 Subject: [PATCH] Add use_journal option for logging configuration This enables oslo.log to pass logging records to journald. Change-Id: I5388e5f39c6ef377bb5e7603305273de4f6566d0 --- manifests/logging.pp | 6 ++++++ ...add-use_journal-option-for-logging-ba712fd13d62d609.yaml | 5 +++++ spec/classes/mistral_logging_spec.rb | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 releasenotes/notes/add-use_journal-option-for-logging-ba712fd13d62d609.yaml diff --git a/manifests/logging.pp b/manifests/logging.pp index 1977844..46b383b 100644 --- a/manifests/logging.pp +++ b/manifests/logging.pp @@ -16,6 +16,10 @@ # (Optional) Use json for logging. # Defaults to $::os_service_default # +# [*use_journal*] +# (Optional) Use journal for logging. +# Defaults to $::os_service_default +# # [*use_stderr*] # (optional) Use stderr for logging # Defaults to $::os_service_default @@ -93,6 +97,7 @@ class mistral::logging( $use_syslog = $::os_service_default, $use_json = $::os_service_default, + $use_journal = $::os_service_default, $use_stderr = $::os_service_default, $log_facility = $::os_service_default, $log_dir = '/var/log/mistral', @@ -127,6 +132,7 @@ class mistral::logging( oslo::log { 'mistral_config': use_syslog => $use_syslog_real, use_json => $use_json, + use_journal => $use_journal, use_stderr => $use_stderr_real, syslog_log_facility => $log_facility_real, log_dir => $log_dir_real, diff --git a/releasenotes/notes/add-use_journal-option-for-logging-ba712fd13d62d609.yaml b/releasenotes/notes/add-use_journal-option-for-logging-ba712fd13d62d609.yaml new file mode 100644 index 0000000..12b190e --- /dev/null +++ b/releasenotes/notes/add-use_journal-option-for-logging-ba712fd13d62d609.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + Adds the use_journal option for configuring oslo.log. This will enable + passing the logs to journald. diff --git a/spec/classes/mistral_logging_spec.rb b/spec/classes/mistral_logging_spec.rb index af1d80b..671961b 100644 --- a/spec/classes/mistral_logging_spec.rb +++ b/spec/classes/mistral_logging_spec.rb @@ -25,6 +25,7 @@ describe 'mistral::logging' do :log_date_format => '%Y-%m-%d %H:%M:%S', :use_syslog => true, :use_json => true, + :use_journal => true, :use_stderr => false, :log_facility => 'LOG_FOO', :log_dir => '/var/log', @@ -59,6 +60,7 @@ describe 'mistral::logging' do is_expected.to contain_oslo__log('mistral_config').with( :use_syslog => '', :use_json => '', + :use_journal => '', :use_stderr => '', :syslog_log_facility => '', :log_dir => '/var/log/mistral', @@ -72,6 +74,7 @@ describe 'mistral::logging' do is_expected.to contain_oslo__log('mistral_config').with( :use_syslog => true, :use_json => true, + :use_journal => true, :use_stderr => false, :syslog_log_facility => 'LOG_FOO', :log_dir => '/var/log',