Add strict validation about boolean parameters

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: Iabbf0e8e9fc46a982f46b2008d6f4fd50ca9ed90

manifests/api.pp

@@ -76,6 +76,9 @@ class mistral::api (
   include mistral::params
   include mistral::policy
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   if $auth_strategy == 'keystone' {
     include mistral::keystone::authtoken
   }

manifests/engine.pp

@@ -69,6 +69,9 @@ class mistral::engine (
   include mistral::deps
   include mistral::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   package { 'mistral-engine':
     ensure => $package_ensure,
     name   => $::mistral::params::engine_package_name,

manifests/event_engine.pp

@@ -40,6 +40,9 @@ class mistral::event_engine (
   include mistral::deps
   include mistral::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   package { 'mistral-event-engine':
     ensure => $package_ensure,
     name   => $::mistral::params::event_engine_package_name,

manifests/executor.pp

@@ -40,6 +40,9 @@ class mistral::executor (
   include mistral::deps
   include mistral::params
 
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+
   package { 'mistral-executor':
     ensure => $package_ensure,
     name   => $::mistral::params::executor_package_name,

manifests/init.pp

@@ -186,6 +186,8 @@ class mistral(
   include mistral::params
   include mistral::db
 
+  validate_legacy(Boolean, 'validate_bool', $sync_db)
+
   package { 'mistral-common':
     ensure => $package_ensure,
     name   => $::mistral::params::common_package_name,