openstack
/
puppet-openstacklib
Code Issues Proposed changes

Merge "Use creates property of exec"

This commit is contained in:
Zuul 2024-03-18 10:31:18 +00:00 committed by Gerrit Code Review
parent fbe39f3ee0 4cfe21d5c9
commit 320b5b9522
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/iscsid.pp
View File

@ -35,7 +35,7 @@ class openstacklib::iscsid(
exec { 'create-initiatorname-file':
command => 'echo "InitiatorName=`/usr/sbin/iscsi-iname`" > /etc/iscsi/initiatorname.iscsi',
path => ['/usr/bin','/usr/sbin','/bin','/usr/bin'],
unless => 'test -e /etc/iscsi/initiatorname.iscsi',
creates => '/etc/iscsi/initiatorname.iscsi',
require => Package['open-iscsi'],
}

2
spec/classes/openstacklib_iscsid_spec.rb
View File

@ -12,7 +12,7 @@ describe 'openstacklib::iscsid' do
it { is_expected.to contain_exec('create-initiatorname-file').with({
:command => 'echo "InitiatorName=`/usr/sbin/iscsi-iname`" > /etc/iscsi/initiatorname.iscsi',
:path => ['/usr/bin','/usr/sbin','/bin','/usr/bin'],
:unless => 'test -e /etc/iscsi/initiatorname.iscsi',
:creates => '/etc/iscsi/initiatorname.iscsi',
}).that_requires('Package[open-iscsi]')}
it { is_expected.to contain_service('iscsid').with(