diff --git a/manifests/db.pp b/manifests/db.pp index 410087f..d813143 100644 --- a/manifests/db.pp +++ b/manifests/db.pp @@ -8,7 +8,7 @@ # Url used to connect to database. # (Optional) Defaults to "sqlite:////var/lib/rally/rally.sqlite". # -# [*database_idle_timeout*] +# [*database_connection_recycle_time*] # Timeout when db connections should be reaped. # (Optional) Defaults to $::os_service_default # @@ -42,22 +42,35 @@ # before error is raised. Set to -1 to specify an infinite retry count. # Defaults to $::os_service_default # +# DEPRECATED PARAMETERS +# +# [*database_idle_timeout*] +# Timeout when db connections should be reaped. +# Defaults to undef. +# class rally::db ( - $database_connection = 'sqlite:////var/lib/rally/rally.sqlite', - $database_idle_timeout = $::os_service_default, - $database_min_pool_size = $::os_service_default, - $database_max_pool_size = $::os_service_default, - $database_max_retries = $::os_service_default, - $database_retry_interval = $::os_service_default, - $database_max_overflow = $::os_service_default, - $database_pool_timeout = $::os_service_default, - $database_db_max_retries = $::os_service_default, + $database_connection = 'sqlite:////var/lib/rally/rally.sqlite', + $database_connection_recycle_time = $::os_service_default, + $database_min_pool_size = $::os_service_default, + $database_max_pool_size = $::os_service_default, + $database_max_retries = $::os_service_default, + $database_retry_interval = $::os_service_default, + $database_max_overflow = $::os_service_default, + $database_pool_timeout = $::os_service_default, + $database_db_max_retries = $::os_service_default, + # DEPRECATED PARAMETERS + $database_idle_timeout = undef, ) { include ::rally::deps + if $database_idle_timeout { + warning('The database_idle_timeout parameter is deprecated. Please use \ +database_connection_recycle_time instead.') + } + $database_connection_real = pick($::rally::database_connection, $database_connection) - $database_idle_timeout_real = pick($::rally::database_idle_timeout, $database_idle_timeout) + $database_connection_recycle_time_real = pick($::rally::database_idle_timeout, $database_idle_timeout, $database_connection_recycle_time) $database_min_pool_size_real = pick($::rally::database_min_pool_size, $database_min_pool_size) $database_max_pool_size_real = pick($::rally::database_max_pool_size, $database_max_pool_size) $database_max_retries_real = pick($::rally::database_max_retries, $database_max_retries) @@ -79,15 +92,15 @@ class rally::db ( } oslo::db { 'rally_config': - connection => $database_connection_real, - idle_timeout => $database_idle_timeout_real, - min_pool_size => $database_min_pool_size_real, - max_pool_size => $database_max_pool_size_real, - max_retries => $database_max_retries_real, - retry_interval => $database_retry_interval_real, - max_overflow => $database_max_overflow_real, - pool_timeout => $database_pool_timeout, - db_max_retries => $database_db_max_retries, + connection => $database_connection_real, + connection_recycle_time => $database_connection_recycle_time_real, + min_pool_size => $database_min_pool_size_real, + max_pool_size => $database_max_pool_size_real, + max_retries => $database_max_retries_real, + retry_interval => $database_retry_interval_real, + max_overflow => $database_max_overflow_real, + pool_timeout => $database_pool_timeout, + db_max_retries => $database_db_max_retries, } } diff --git a/releasenotes/notes/deprecate_idle_timeout_parameter-a84ada9b96db64d2.yaml b/releasenotes/notes/deprecate_idle_timeout_parameter-a84ada9b96db64d2.yaml new file mode 100644 index 0000000..09e76c4 --- /dev/null +++ b/releasenotes/notes/deprecate_idle_timeout_parameter-a84ada9b96db64d2.yaml @@ -0,0 +1,4 @@ +--- +deprecations: + - database_idle_timeout is deprecated and will be removed in a future + release. Please use database_connection_recycle_time instead. diff --git a/spec/classes/rally_db_spec.rb b/spec/classes/rally_db_spec.rb index 0b9e03e..3d15486 100644 --- a/spec/classes/rally_db_spec.rb +++ b/spec/classes/rally_db_spec.rb @@ -6,15 +6,15 @@ describe 'rally::db' do it { should contain_class('rally::deps') } it { should contain_oslo__db('rally_config').with( - :db_max_retries => '', - :connection => 'sqlite:////var/lib/rally/rally.sqlite', - :idle_timeout => '', - :min_pool_size => '', - :max_pool_size => '', - :max_retries => '', - :retry_interval => '', - :max_overflow => '', - :pool_timeout => '', + :db_max_retries => '', + :connection => 'sqlite:////var/lib/rally/rally.sqlite', + :connection_recycle_time => '', + :min_pool_size => '', + :max_pool_size => '', + :max_retries => '', + :retry_interval => '', + :max_overflow => '', + :pool_timeout => '', )} it { should contain_file('/var/lib/rally').with( @@ -29,30 +29,30 @@ describe 'rally::db' do context 'with specific parameters' do let :params do { - :database_connection => 'mysql://rally:rally@localhost/rally', - :database_idle_timeout => '3601', - :database_min_pool_size => '2', - :database_max_retries => '11', - :database_retry_interval => '11', - :database_max_pool_size => '11', - :database_max_overflow => '21', - :database_pool_timeout => '21', - :database_db_max_retries => '-1', + :database_connection => 'mysql://rally:rally@localhost/rally', + :database_connection_recycle_time => '3601', + :database_min_pool_size => '2', + :database_max_retries => '11', + :database_retry_interval => '11', + :database_max_pool_size => '11', + :database_max_overflow => '21', + :database_pool_timeout => '21', + :database_db_max_retries => '-1', } end it { should contain_class('rally::deps') } it { should contain_oslo__db('rally_config').with( - :db_max_retries => '-1', - :connection => 'mysql://rally:rally@localhost/rally', - :idle_timeout => '3601', - :min_pool_size => '2', - :max_pool_size => '11', - :max_retries => '11', - :retry_interval => '11', - :max_overflow => '21', - :pool_timeout => '21', + :db_max_retries => '-1', + :connection => 'mysql://rally:rally@localhost/rally', + :connection_recycle_time => '3601', + :min_pool_size => '2', + :max_pool_size => '11', + :max_retries => '11', + :retry_interval => '11', + :max_overflow => '21', + :pool_timeout => '21', )} it { should_not contain_file('create_sqlite_directory') }