From f687aa3909288ad4c4f34d5da89afa97139fb400 Mon Sep 17 00:00:00 2001 From: ZhongShengping Date: Mon, 15 Jan 2018 16:32:33 +0800 Subject: [PATCH] Add use_journal option for logging configuration This enables oslo.log to pass logging records to journald. Change-Id: I51411d8fcea59d828f2d1c6c179d78c9ab516a0e --- manifests/logging.pp | 6 ++++++ ...add-use_journal-option-for-logging-96ae85ddf08d29ef.yaml | 5 +++++ spec/classes/vitrage_logging_spec.rb | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 releasenotes/notes/add-use_journal-option-for-logging-96ae85ddf08d29ef.yaml diff --git a/manifests/logging.pp b/manifests/logging.pp index 239782f..90550f8 100644 --- a/manifests/logging.pp +++ b/manifests/logging.pp @@ -17,6 +17,10 @@ # (Optional) Use json for logging. # Defaults to $::os_service_default # +# [*use_journal*] +# (Optional) Use journal for logging. +# Defaults to $::os_service_default +# # [*use_stderr*] # (optional) Use stderr for logging # Defaults to $::os_service_default @@ -94,6 +98,7 @@ class vitrage::logging( $use_syslog = $::os_service_default, $use_json = $::os_service_default, + $use_journal = $::os_service_default, $use_stderr = $::os_service_default, $log_facility = $::os_service_default, $log_dir = '/var/log/vitrage', @@ -129,6 +134,7 @@ class vitrage::logging( debug => $debug_real, use_syslog => $use_syslog_real, use_json => $use_json, + use_journal => $use_journal, use_stderr => $use_stderr_real, log_dir => $log_dir_real, syslog_log_facility => $log_facility_real, diff --git a/releasenotes/notes/add-use_journal-option-for-logging-96ae85ddf08d29ef.yaml b/releasenotes/notes/add-use_journal-option-for-logging-96ae85ddf08d29ef.yaml new file mode 100644 index 0000000..12b190e --- /dev/null +++ b/releasenotes/notes/add-use_journal-option-for-logging-96ae85ddf08d29ef.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + Adds the use_journal option for configuring oslo.log. This will enable + passing the logs to journald. diff --git a/spec/classes/vitrage_logging_spec.rb b/spec/classes/vitrage_logging_spec.rb index b69f7df..2130a47 100644 --- a/spec/classes/vitrage_logging_spec.rb +++ b/spec/classes/vitrage_logging_spec.rb @@ -25,6 +25,7 @@ describe 'vitrage::logging' do :log_date_format => '%Y-%m-%d %H:%M:%S', :use_syslog => true, :use_json => true, + :use_journal => true, :use_stderr => false, :log_facility => 'LOG_FOO', :log_dir => '/var/log', @@ -59,6 +60,7 @@ describe 'vitrage::logging' do is_expected.to contain_oslo__log('vitrage_config').with( :use_syslog => '', :use_json => '', + :use_journal => '', :use_stderr => '', :syslog_log_facility => '', :log_dir => '/var/log/vitrage', @@ -72,6 +74,7 @@ describe 'vitrage::logging' do is_expected.to contain_oslo__log('vitrage_config').with( :use_syslog => true, :use_json => true, + :use_journal => true, :use_stderr => false, :syslog_log_facility => 'LOG_FOO', :log_dir => '/var/log',