openstack
/
puppet-vswitch
Code Issues Proposed changes

vs_bridge: Skip redundant update when updating external_ids 

We don't have to set the id in case the id already exists and has
the expected value.

Change-Id: I2b02b43aff5e35dac2b29beff572472a8039c6f0
This commit is contained in:
Takashi Kajinami 2023-11-21 13:11:51 +09:00
parent 808e3104a2
commit 543556dcd1
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/puppet/provider/vs_bridge/ovs.rb
View File

@ -55,7 +55,9 @@ Puppet::Type.type(:vs_bridge).provide(:ovs) do
new_ids = _split(value)
new_ids.each do |k,v|
vsctl('br-set-external-id', br, k, v)
if !old_ids.has_key?(k) or old_ids[k] != v
vsctl('br-set-external-id', br, k, v)
end
end
old_ids.each do |k, v|

3
spec/unit/provider/vs_bridge/ovs_spec.rb
View File

@ -112,9 +112,6 @@ describe Puppet::Type.type(:vs_bridge).provider(:ovs) do
).and_return('k1=v1
k2=v2
k3=v3')
expect(described_class).to receive(:vsctl).with(
'br-set-external-id', 'testbr', 'k1', 'v1'
)
expect(described_class).to receive(:vsctl).with(
'br-set-external-id', 'testbr', 'k2', 'v2new'
)