Clean up parameters for service validation

... service validation was deprecated during Yoga cycle by [1].
The parameters were left for interface compatibility but have had no
effect since then.

[1] 3d5c217596

Change-Id: Ied5d81d7782f07a7cc6488a98a3a9e966fb6c6fa

manifests/api.pp

@@ -71,20 +71,6 @@
 #   (optional) Type of authentication to be used.
 #   Defaults to 'keystone'
 #
-# DEPRECATED PARAMETERS
-#
-# [*validate*]
-#   (Optional) Whether to validate the service is working after any service
-#   refreshes
-#   Defaults to undef
-#
-# [*validation_options*]
-#   (Optional) Service validation options
-#   Should be a hash of options defined in openstacklib::service_validation
-#   If empty, defaults values are taken from openstacklib function.
-#   Require validate set at True.
-#   Defaults to undef
-#
 class watcher::api (
   $package_ensure     = 'present',
   $enabled            = true,
@@ -98,21 +84,11 @@ class watcher::api (
   $create_db_schema   = false,
   $upgrade_db         = false,
   $auth_strategy      = 'keystone',
-  # DEPRECATED PARAMETERS
-  $validate           = undef,
-  $validation_options = undef,
 ) inherits watcher::params {
 
   include watcher::policy
   include watcher::deps
 
-  if $validate != undef {
-    warning('The watcher::api::validate parameter has been deprecated and has no effect')
-  }
-  if $validation_options != undef {
-    warning('The watcher::api::validation_options parameter has been deprecated and has no effect')
-  }
-
   if $auth_strategy == 'keystone' {
     include watcher::keystone::authtoken
   }

releasenotes/notes/remove-service-validation-112f0bc7d169ad87.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The ``validate`` parameter and the ``validation_options`` parameter of
+    the ``watcher::api`` class have been removed.