openstack
/
python-ceilometerclient
Code Issues Proposed changes

Handle log message interpolation by the logger 

According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Change-Id: Ia2bcd4387c406a3f7ffdb3cfe0badeccca22f278
Closes-Bug: #1661262
This commit is contained in:
Gábor Antal 2017-02-07 14:45:49 +01:00
parent 4bd78939bc
commit 2d0529347d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ceilometerclient/apiclient/client.py
View File

@ -128,9 +128,9 @@ class HTTPClient(object):
self._safe_header(element, kwargs['headers'][element]))
string_parts.append(header)
_logger.debug("REQ: %s" % " ".join(string_parts))
_logger.debug("REQ: %s", " ".join(string_parts))
if 'data' in kwargs:
_logger.debug("REQ BODY: %s\n" % (kwargs['data']))
_logger.debug("REQ BODY: %s\n", kwargs['data'])
def _http_log_resp(self, resp):
if not self.debug: