From 8744c636c1cb8924edd1f3a1e7d3dab467e23ad0 Mon Sep 17 00:00:00 2001 From: ls1175 Date: Sat, 18 Jan 2014 15:21:31 +0800 Subject: [PATCH] replace assertTrue(isinstance) to assertIsInstance some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools Change-Id: Idd931d27b13a46800e27393a98da096d41442320 Closes-bug: #1268480 --- ceilometerclient/tests/v2/test_alarms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ceilometerclient/tests/v2/test_alarms.py b/ceilometerclient/tests/v2/test_alarms.py index 6665ef76..edccb4bc 100644 --- a/ceilometerclient/tests/v2/test_alarms.py +++ b/ceilometerclient/tests/v2/test_alarms.py @@ -323,7 +323,7 @@ class AlarmManagerTest(testtools.TestCase): self.assertEqual(self.api.calls, expect) for i in xrange(len(history)): change = history[i] - self.assertTrue(isinstance(change, alarms.AlarmChange)) + self.assertIsInstance(change, alarms.AlarmChange) for k, v in six.iteritems(ALARM_HISTORY[i]): self.assertEqual(getattr(change, k), v)